Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ServiceManager.stopTimes() to enable debugging slow ServiceManager shutdowns #5842

Open
Kurru opened this issue Dec 22, 2021 · 3 comments · May be fixed by #5903
Open

Provide ServiceManager.stopTimes() to enable debugging slow ServiceManager shutdowns #5842

Kurru opened this issue Dec 22, 2021 · 3 comments · May be fixed by #5903
Labels
P3 package=concurrent status=triaged type=addition A new feature

Comments

@Kurru
Copy link

Kurru commented Dec 22, 2021

Consider providing ServiceManager.stopTimes() to enable debugging slow ServiceManager shutdowns.

There currently exists serviceManager.startupTimes() for startup time, this would be the equivalent for the shutdown process.
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 17, 2022
google#5842 stopTimers capture in ServiceManager
f9f6589
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 17, 2022
google#5842 stopTimers capture in ServiceManager
2a0f719
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 17, 2022
google#5842 stopTimers capture in ServiceManager
3232403
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 17, 2022
google#5842 stopTimers capture in ServiceManager
32b108f
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 17, 2022
google#5842 stopTimers capture in ServiceManager
36ac5ae
@ayushjais2654
Copy link

ayushjais2654 commented Jan 17, 2022 •
edited
Loading

@Kurru I have raised the pull request for the requested support. Please refer #5873

@ayushjais2654 ayushjais2654 mentioned this issue Jan 17, 2022
Closed
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 18, 2022
google#5842 stopTimers capture in ServiceManager
30c6e74
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 18, 2022
google#5842 stopTimers capture in ServiceManager
571b0c7
ayushjais2654 pushed a commit to ayushjais2654/guava that referenced this issue Jan 28, 2022
@ayushjais2654
google#5842 stopTimers capture in ServiceManager
08ac7e7
@ayushjais2654 ayushjais2654 linked a pull request Jan 28, 2022 that will close this issue
Open
@netdpb
Copy link
Member

netdpb commented Feb 7, 2022

Do you actually have a use case for this feature? What will you use it for? Or are you proposing it simply for completeness?

@Kurru
Copy link
Author

Kurru commented Feb 8, 2022

When I start my server I print out the time taken to start all services, which is easy given the current supported API. This lets me see which service was responsible for slow server start performance.

I want the same ability for server shutdown. Currently, when I stop my server, it waits for all services to stop running, however I have no easy visibility into the shutdown delay which is frustrating.

Slow shutdown services have occurred within my server on several occasions. When this happens, it is very hard to attribute this back to the appropriate service, as I don't know which service is still 'running'. This API would give me an easy retrospective view into 'oh service x took 23 seconds to stop, let me investigate how that could happen'.

Typically this has been due to a slow, blocking rpc call within a scheduled service, or a blocking retry within the run block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 package=concurrent status=triaged type=addition A new feature
Projects
None yet
Milestone
No milestone
4 participants
@netdpb @Kurru @chaoren @ayushjais2654