Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gts check enforces eol=lf on Windows #485

Open
dotdoom opened this issue Apr 11, 2020 · 1 comment
Open

gts check enforces eol=lf on Windows #485

dotdoom opened this issue Apr 11, 2020 · 1 comment

Comments

@dotdoom
Copy link

dotdoom commented Apr 11, 2020

This one may be WAI because gts is supposed to be opinionated. But with default git settings, which instruct git to automatically convert LF to CRLF for text files on Windows, it is not working well out of the box. More about this in https://eslint.org/docs/rules/linebreak-style#using-this-rule-with-version-control-systems ("Using this rule with version control systems" section).

Anyway, if the intention is to leave the enforcement with "unix", maybe you'd like to add this link to README?


For posterity: I'm getting these errors from our CI which builds on Windows (btw -- doesn't happen on Mac builds):

src\index.ts
##[error]    1:48   error  Delete `␍`  prettier/prettier
##[error]    2:50   error  Delete `␍`  prettier/prettier
##[error]    3:50   error  Delete `␍`  prettier/prettier
##[error]    4:26   error  Delete `␍`  prettier/prettier
##[error]    5:28   error  Delete `␍`  prettier/prettier
...
@dobromyslov
Copy link

Tried GTS in my project managed by Git and got lots of such errors. I completely agree that this behavior on Windows machines should be mentioned in the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants