-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for java.sql types #1629
Comments
gson/gson/src/main/java/module-info.java Line 11 in 1a9469a
Would have to be changed as well, right? |
I am not as familiar with Java 10+ (as have stayed mostly with Android). So, if someone was willing to write a PR that maintains full backward compatibilty, I will take a look. |
Lol, it can't be backward compatible because of "Remove support". |
I think it can be backwards compatible by using an optional module dependency ( |
Wonderful! |
Created #1707 now. Though I am not that familiar with the module system so any feedback is appreciated! |
The original idea #134 was OK in 2015. Since then, Java got modular support and java.sql is no longer available by default. This is causing sporadic issues in random places:
Would be great to deprecate support for java.sql and suggest writing type adapters instead.
The text was updated successfully, but these errors were encountered: