LocationOfInterestRepository.getOfflineLoi java.lang.IllegalStateException - LOI not found

[anandwana001]

 Fatal Exception: java.lang.IllegalStateException: LOI not found: uJcwRNB9BB7yPwGhrKF6
       at com.google.android.ground.repository.LocationOfInterestRepository.getOfflineLoi(LocationOfInterestRepository.kt:93)
       at com.google.android.ground.repository.LocationOfInterestRepository$getOfflineLoi$1.invokeSuspend(:15)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:230)
       at android.os.Looper.loop(Looper.java:319)
       at android.app.ActivityThread.main(ActivityThread.java:8913)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)
        

Total events by version
0.1.10 (20)
15
for the last 7 days

[anandwana001]

@shobhitagarwal1612 is this the correct user behaviour?

as per the code

 suspend fun getOfflineLoi(surveyId: String, loiId: String): LocationOfInterest {
    val survey = localSurveyStore.getSurveyById(surveyId) ?: error("Survey not found: $surveyId")
    return localLoiStore.getLocationOfInterest(survey, loiId) ?: error("LOI not found: $loiId")
  }

it should crash, but, is it good to crash or should we do something better for the user behaviour?

[shobhitagarwal1612]

Are you sure that the application is crashing?

[anandwana001]

it says Fatal Exception, so I am assuming its an app crash.
And, error("LOI not found: $loiId") throw exception so it should crash.

WDYT?

BTW, the stack trace is from firebase.

[shobhitagarwal1612]

From crash logs I found that this is happening in SyncStatusFragment. In this particular usecase, the code isn't wrapped around a try-catch block. So the app must be getting crashed when opening the sync status screen. Can you please try to understand how this is happening and the root cause for the LOIs to be missing?