Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide binaries and releases #21

Closed
gssbzn opened this issue May 25, 2020 · 8 comments
Closed

Provide binaries and releases #21

gssbzn opened this issue May 25, 2020 · 8 comments

Comments

@gssbzn
Copy link

gssbzn commented May 25, 2020

Hi, I was wondering if it would be possible to provide proper release versions and binaries along with them?
Today we hit a weird issue on our CI as github.com/otiai10/copy introduced a breaking change on their latest release and the way we were installing go-licenses was triggering this problem, our CI is a bit weird but so far we managed to solve it with some extra conf but having a binary we can just download and run would solve this kind of issue (not to mention that is also usually faster to do it like that)

So leaving this here for consideration

@DylanMeeus
Copy link

Running into the same issue here :/

@gssbzn
Copy link
Author

gssbzn commented May 27, 2020

@DylanMeeus the way we solved this was running go get with GO111MODULE=on, we just had to go thru some hoops on our ci as running go get with GO111MODULE=on in a folder with a go.mod file will add the dependency to the file (this is a known "feature" with no way around it so far) and we did not want that on our ci, hence why I think binaries would help a lot

@DylanMeeus
Copy link

Thanks @gssbzn, I'll give that a try!
Luckily nothing urgent though as we don't update our external dependencies all that often. Having release tags would help a great deal in preventing these issues :-)

@RJPercival
Copy link
Contributor

Would a Docker image suffice? There's already a Dockerfile that should always build, and it should be relatively easy to release Docker images.

@gssbzn
Copy link
Author

gssbzn commented May 28, 2020

@RJPercival it would be a start for sure, our ci doesn't have the best docker support but we are working on it.
I also have some experience setting up goreleaser if that's an approach some of the contributors are willing to try I'm happy to make a PR but having something like that means the maintainers are happy to at least tag the release

@RJPercival
Copy link
Contributor

RJPercival commented May 28, 2020

They should be happy to tag a release; the v1 milestone is complete so I think it's ready for a v1.0.0 tag. I'm not so sure about goreleaser; they'll have to chime in there.

@gssbzn
Copy link
Author

gssbzn commented Feb 18, 2021

with go1.16 I think this can be closed as in theory now there's an option to not alter the the go.mod file, I still need to test this on our CI env as we are still adding 1.16 support

@Bobgy
Copy link
Collaborator

Bobgy commented Apr 11, 2022

There are releases now and with go1.16+ go install github.com/google/go-licenses@latest, I think these problems are addressed. Please comment if it's still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants