Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow merging PullRequests with commitMessage unspecified #1448

Closed
pratikmallya opened this issue Mar 1, 2020 · 0 comments · Fixed by #1447
Closed

Allow merging PullRequests with commitMessage unspecified #1448

pratikmallya opened this issue Mar 1, 2020 · 0 comments · Fixed by #1447

Comments

@pratikmallya
Copy link
Contributor

If the commitMessage is unspecified, merging a PR with squash merge commit results in commit with concatenated text from all source commits. example.

This field should be omitted when the commit message is empty; in that case on squash merge this behavior would be triggered.

I do concede it would be a small change in behavior; if a current user is expecting the squash merge with empty commit message to really have an empty commit message. Not sure how to differentiate between wanting to force an empty commit message and wanting the desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant