crane: crane copy is not working in 0.10

[janosmiko]

Describe the bug

I'm trying to copy images from a GitLab registry to a Harbor registry using the latest version of Crane (0.10).

To Reproduce

bash-5.1# crane version
0.10.0
bash-5.1# crane copy registry.gitlabexample.com/examplegroup/examplerepo/image:main registry.harborexample.com/target/target:main
2022/06/23 11:12:00 Copying from registry.gitlabexample.com/examplegroup/examplerepo/image:main to registry.harborexample.com/target/target:main
Error: failed to copy image: POST registry.harborexample.com/v2/target/target:main/blobs/uploads/?from=examplegroup%2Fexamplerepo%2Fimage&mount=sha256%3A0568686c22c248c1ef8ae00f5baa5d660cb5dcd3424e63a60d9c9b9b71e39785&origin=REDACTED: UNAUTHORIZED: project examplegroup not found: project examplegroup not found

Expected behavior

When I revert to 0.9, it works as expected.

bash-5.1# crane version
0.9.0
bash-5.1# crane copy registry.example.com/examplegroup/examplerepo/image:main registry.harborexample.com/target/target:main
2022/06/23 11:18:06 Copying from registry.example.com/examplegroup/examplerepo/image:main to registry.harborexample.com/target/target:main
2022/06/23 11:18:12 pushed blob: sha256:0568686c22c248c1ef8ae00f5baa5d660cb5dcd3424e63a60d9c9b9b71e39785
2022/06/23 11:18:12 pushed blob: sha256:c78c48e60064d4d5592af2c868e99063f54b6a44f8c309f1c4f370c378ecce6f
...

[imjasonh]

@jonjohnsonjr seems related to cross origin mounting?

[jonjohnsonjr]

This is a bug in harbor.

They SHOULD return a 202 here:

Alternatively, if a registry does not support cross-repository mounting or is unable to mount the requested blob, it SHOULD return a 202. This indicates that the upload session has begun and that the client MAY proceed with the upload..

If a mount fails due to invalid repository or digest arguments, the registry will fall back to the standard upload behavior and return a 202 Accepted with the upload URL in the Location header:

Can you file a bug against them? We could have an allowlist for registries we expect this to work with, or a denylist for registries we know it breaks, but that makes it difficult to adopt :/

[janosmiko]

What about a command-line flag to support this old behavior?

[janosmiko]

I updated my Harbor instance from (2.4.x) to the latest version (2.5.1) and it seems like it's working again with Crane 0.10.

Thanks for the help!

[imjasonh]

That's great to hear! We might just want to document that this behavior breaks on Harbor <v2.5, if that's already fixed.

[adriannieto-attechnest]

Just to note that we are experiencing this bug in latest harbor version in the helm chart (Version v2.5.1-b0506782) @imjasonh how did you fix the issue?