-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #370
Fix warnings #370
Conversation
Fixed these warnings: src/logging_unittest.cc: At global scope: src/logging_unittest.cc:1081:13: warning: 'void MyCheck(bool, bool)' defined but not used [-Wunused-function] static void MyCheck(bool a, bool b) { ^~~~~~~ src/logging_unittest.cc:1078:13: warning: 'void MyFatal()' defined but not used [-Wunused-function] static void MyFatal() { ^~~~~~~
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
static void MyFatal() { | ||
LOG(FATAL) << "Failed"; | ||
} | ||
static void MyCheck(bool a, bool b) { | ||
CHECK_EQ(a, b); | ||
} | ||
|
||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for keeping the functions in a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking if someone might want to use them in future. If you think they should be removed, please let me know
Fixed these warnings: