-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.0: test suite is failing in four units #887
Comments
Is this still a problem with glog at head? |
I'm closing the issue in preparation for new release. In case the problem persists, please submit a new issue with an updated log. |
I don't see any commits added after last release related to this issue and just retested issue sill is present. |
Just tested 0.6.0 + all 130 commits added after release. Here is result of the test suite and one unit still fails+ cd glog-0.6.0
+ /usr/bin/ctest --test-dir x86_64-redhat-linux-gnu --output-on-failure --force-new-ctest-process -j48 ' '
Internal ctest changing into directory: /home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu
Test project /home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu
Start 7: cmake_package_config_init
Start 11: cleanup_init
Start 1: demangle
1/26 Test #1: demangle .........................***Not Run (Disabled) 0.00 sec
Start 2: logging
Start 3: signalhandler
Start 4: stacktrace
Start 5: stl_logging
Start 6: symbolize
Start 16: striplog0
Start 17: striplog2
Start 18: striplog10
Start 19: log_severity_constants
Start 20: log_severity_conversion
Start 21: includes_logging
Start 22: includes_vlog_is_on
Start 23: includes_raw_logging
Start 24: includes_stl_logging
Start 25: dcheck_on
Start 26: dcheck_off
2/26 Test #26: dcheck_off .......................***Not Run (Disabled) 0.00 sec
3/26 Test #7: cmake_package_config_init ........ Passed 0.04 sec
Start 8: cmake_package_config_generate
4/26 Test #11: cleanup_init ..................... Passed 0.04 sec
Start 13: cleanup_immediately
Start 14: cleanup_with_absolute_prefix
Start 15: cleanup_with_relative_prefix
5/26 Test #3: signalhandler .................... Passed 0.04 sec
6/26 Test #5: stl_logging ...................... Passed 0.04 sec
7/26 Test #6: symbolize ........................ Passed 0.04 sec
8/26 Test #16: striplog0 ........................ Passed 0.03 sec
9/26 Test #17: striplog2 ........................ Passed 0.03 sec
10/26 Test #18: striplog10 ....................... Passed 0.03 sec
11/26 Test #13: cleanup_immediately .............. Passed 0.04 sec
12/26 Test #14: cleanup_with_absolute_prefix ..... Passed 0.04 sec
13/26 Test #15: cleanup_with_relative_prefix ..... Passed 0.04 sec
Start 12: cleanup_logdir
14/26 Test #12: cleanup_logdir ................... Passed 0.01 sec
15/26 Test #4: stacktrace .......................Subprocess aborted***Exception: 0.14 sec
Obtained 9 stack frames.
Obtained 9 stack frames.
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0x1e485) [0x5609170c8485] 0x5609170c8485
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0x1e677) [0x5609170c8677] 0x5609170c8677
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0x1e857) [0x5609170c8857] 0x5609170c8857
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0x1ea37) [0x5609170c8a37] 0x5609170c8a37
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0x1ebe7) [0x5609170c8be7] 0x5609170c8be7
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0x9a74) [0x5609170b3a74] 0x5609170b3a74
/lib64/libc.so.6(+0x2814a) [0x7f1a8364514a] 0x7f1a8364514a
/lib64/libc.so.6(__libc_start_main+0x8b) [0x7f1a8364520b] 0x7f1a8364520b
/home/tkloczko/rpmbuild/BUILD/glog-0.6.0/x86_64-redhat-linux-gnu/stacktrace_unittest(+0xadd5) [0x5609170b4dd5] 0x5609170b4dd5
CheckStackTrace() addr: 0x5609170c8b90
Backtrace 0: expected: 0x5609170c7fc7..0x5609170c811b actual: 0x5609170c8485 ... F20240110 10:49:18.937953 139751855402560 stacktrace_unittest.cc:114] Check failed: ret_addr <= range.end (0x5609170c8485 vs. 0x5609170c811b)
*** Check failure stack trace: ***
@ 0x5609170d2b5c google::LogMessage::SendToLog()
@ 0x5609170b8906 google::LogMessage::Flush()
@ 0x5609170c824a CheckStackTraceLeaf()
@ 0x5609170c8485 CheckStackTrace4(int)
@ 0x5609170c8677 CheckStackTrace3(int)
@ 0x5609170c8857 CheckStackTrace2(int)
@ 0x5609170c8a37 CheckStackTrace1(int)
@ 0x5609170c8be7 CheckStackTrace(int)
@ 0x5609170b3a74 main
@ 0x7f1a8364514a __libc_start_call_main
@ 0x7f1a8364520b __libc_start_main_alias_2
@ 0x5609170b4dd5 _start
16/26 Test #2: logging .......................... Passed 0.26 sec
17/26 Test #8: cmake_package_config_generate .... Passed 0.68 sec
Start 9: cmake_package_config_build
18/26 Test #22: includes_vlog_is_on .............. Passed 1.26 sec
19/26 Test #23: includes_raw_logging ............. Passed 1.26 sec
20/26 Test #20: log_severity_conversion .......... Passed 1.32 sec
21/26 Test #19: log_severity_constants ........... Passed 1.33 sec
22/26 Test #24: includes_stl_logging ............. Passed 1.43 sec
23/26 Test #9: cmake_package_config_build ....... Passed 0.87 sec
Start 10: cmake_package_config_cleanup
24/26 Test #10: cmake_package_config_cleanup ..... Passed 0.02 sec
25/26 Test #21: includes_logging ................. Passed 1.67 sec
26/26 Test #25: dcheck_on ........................ Passed 1.72 sec
96% tests passed, 1 tests failed out of 24
Total Test time (real) = 1.76 sec
The following tests did not run:
1 - demangle (Disabled)
26 - dcheck_off (Disabled)
The following tests FAILED:
4 - stacktrace (Subprocess aborted)
Errors while running CTest |
Thanks! |
BTW is it any reason why glog.pc file is no longer installed? 🤔 |
There are several reasons why pkg-config is no longer installed by default:
You can however opt in for generating the |
cmake support is 100% procedural. On packaging layer procedural description is easy on generate |
I certainly disagree. There is also no point arguing since you can enable |
cmake settings:
and test suite is failing:
The text was updated successfully, but these errors were encountered: