Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest usage not implemented in CMake build system #510

Closed
Arfrever opened this issue Dec 23, 2019 · 0 comments · Fixed by #621
Closed

gtest usage not implemented in CMake build system #510

Arfrever opened this issue Dec 23, 2019 · 0 comments · Fixed by #621
Assignees
Labels
Milestone

Comments

@Arfrever
Copy link

 $ grep -i gtest configure.ac CMakeLists.txt
configure.ac:AC_CHECK_PROG(GTEST_CONFIG, gtest-config, "yes")
configure.ac:AC_CHECK_LIB(gtest, main, have_gtest_lib="yes")
configure.ac:if test x"$GTEST_CONFIG" = "xyes" -a x"$have_gtest_lib" = "xyes"; then
configure.ac:  GTEST_CFLAGS=`gtest-config --cppflags --cxxflags`
configure.ac:  GTEST_LIBS=`gtest-config --ldflags --libs`
configure.ac:  AC_DEFINE(HAVE_LIB_GTEST, 1, [define if you have google gtest library])
configure.ac:  GTEST_CFLAGS=
configure.ac:  GTEST_LIBS=
configure.ac:AC_SUBST(GTEST_CFLAGS)
configure.ac:AC_SUBST(GTEST_LIBS)
$ grep -r HAVE_LIB_GTEST *
configure.ac:  AC_DEFINE(HAVE_LIB_GTEST, 1, [define if you have google gtest library])
src/config.h.cmake.in:#cmakedefine HAVE_LIB_GTEST
src/googletest.h:#ifdef HAVE_LIB_GTEST
src/googletest.h:#endif  // ! HAVE_LIB_GTEST

When using CMake, #cmakedefine HAVE_LIB_GTEST is currently always expanded to /* #undef HAVE_LIB_GTEST */.

@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud added the bug label Mar 30, 2021
@sergiud sergiud self-assigned this Mar 30, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants