Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to detect incomplete locking of v1-encrypted directory #215

Closed
ebiggers opened this issue Apr 1, 2020 · 0 comments · Fixed by #217
Closed

Try to detect incomplete locking of v1-encrypted directory #215

ebiggers opened this issue Apr 1, 2020 · 0 comments · Fixed by #217

Comments

@ebiggers
Copy link
Collaborator

ebiggers commented Apr 1, 2020

Unlike v2, fscrypt lock on a v1-encrypted directory doesn't warn about in-use files, as the kernel doesn't provide a way to easily detect it. In #214 this caused some confusion.

It might be possible to implement a heuristic where we check whether the filenames in the directory seem to be no-key names or not. If yes, the directory is fully locked, otherwise it's incompletely locked (or unlocked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant