-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does Roboto not display in Firefox Nightly? #738
Comments
Here is a related comment from Firefox's bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1331797#c19 |
Thanks @sucrose and @scheinercc :) Will take a look at this! |
I receive similar errors in console, win 10 Firefox 54.02a (2017-05-11) (32-bit) |
Any update on this? |
Seeing the same issue.
Requested URL
Console output
|
+1 |
there's soluction to this problem? |
I'm not able to replicate this with Firefox 55.0b2 (64 bit). I'm guessing Mozilla changed the settings for OTS sanitizer in 54.0a2 and have now reverted them back. |
It is fine in 55 (macOS; beta/dev) indeed, though the issue still there in current nightly (v56). Default setting for gfx.downloadable_fonts.otl_validation in v55 currently is 'false' while in v56 it is (still!?) 'true'. |
Only the nightly Firefox builds specifically should have |
Maybe @sucrose can change the title to "Roboto not displaying in Firefox Nightly (gfx.downloadable_fonts.otl_validation set to true)" or similar? |
OpenType spec v1.8.2 released recently (http://typedrawers.com/discussion/2276/opentype-1-8-2-released#latest) which changes the spec to make this valid. |
The solution is going to be for OTS to be updated by @khaledhosny to reflect the latest spec, and for that to trickle down to Firefox. |
Per khaledhosny/ots#131 and https://bugzilla.mozilla.org/show_bug.cgi?id=1331797#c29 I was wrong about this; we now see Nightly has the latest OTS (https://github.com/khaledhosny/ots/) but the problem persists, and Khaled has confirmed that OTS should not be changed to allow the error. (Also, I found the overall rationale for using OTS is in https://bugzilla.mozilla.org/show_bug.cgi?id=964696#c5) So, since the fonts imported into the Google Fonts API are valid, and OTS is valid in rejecting the fonts exported from the API, the issue lies with the https://github.com/fonttools/fonttools subsetter which the GF API uses. I hope someone at Mozilla can provide a patch. |
@behdad has fixed the underlying problem in the fonttools subsetter - Thank you Behdad!!! |
We're still seeing invalid Roboto resources served by Google Fonts; e.g.
Any chance the fix could get deployed sometime soon? |
Soon! :) |
FYI, Roboto is working for me in Nightly 58.0a1 (2017-09-30) When I load all fonts, I get the error "Native load test failed:" for these fonts:
|
I didn't check all of these, but at least the first few seem to have a different problem than the missing defaultLangSys that was the problem in Roboto: downloadable font: Layout: Lookup flags require GDEF table, but none was found: 8 (font-family: "Pangolin script=latin rev=1" style:normal weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=Fs3vif300i0sWG_8cwtUgWadrG7xQ6Sn31MgoLunhwSlWBXZHJxtwUAuAQMHUQarESqeeMWmvUdEBTEQHmkQAw&skey=3db57adcfc639c2d&v=v2 downloadable font: Layout: Lookup flags require GDEF table, but none was found: 8 (font-family: "Philosopher script=latin rev=1" style:normal weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=oZLTrB9jmJsyV0u_T0TKERMNIvgBSNmnIXwlL72ISo046TfR3Aq3eiTq1JszwU6rue2wV9aw1mLs183lDYuodg&skey=da0a2147adba7eff&v=v8 downloadable font: Layout: Lookup flags require GDEF table, but none was found: 8 (font-family: "Sedgwick Ave Display script=latin rev=1" style:normal weight:normal stretch:normal src index:0) source: https://fonts.gstatic.com/l/font?kit=_2bQpgd1Hl3UOD3yDrU-cM0XQamUJZ2addZRR_tQTxY1Ucq_GzRNXE4T8CP-2p4q5RA8htVOKoTC4wIMmGrJKqNRLSGfS6bMLReYoLlofcI&skey=bd380dabc39e09ab&v=v2 |
That's BS. The spec is clear that GDEF glyph classes may be automatically synthesized. I suggest we stop wasting Google's and Khaled's time and resources on fixing this crap of a code that is GSUB/GPOS/GDEF in OTS and let Firefox do whatever they want. They apparently have not been caring enough to fix the code themselves or just disable it as it should be. @khaledhosny I suggest you remove that code from OTS. Jonathan can maintain a fork if he wants. This is my last comment on this matter. |
According to https://www.microsoft.com/typography/otspec/chapter2.htm, under LookupFlag bit enumeration: "IgnoreBaseGlyphs, IgnoreLigatures, or IgnoreMarks refer to base glyphs, ligatures and marks as defined in the Glyph Class Definition Table in the GDEF table. If any of these flags are set, a Glyph Class Definition Table must be present." That's what OTS is implementing here, AFAICS. Is there another part of the spec that contradicts this? If so, please point it out, as we should ask for the inconsistency to be resolved in the spec. |
@scheinercc, unfortunately, I just tried loading the Google Fonts Roboto page with a completely fresh profile with today's Firefox nightly, and it's still not showing any text (I get the same "Native load test failed:" messages on that page) :( A CDN propagation issue, perhaps? |
Ah, interesting. @wisniewskit thanks for checking! |
This only affects Firefox Nightly, right? Beta and Stable already disable OTS sanitizing of OTL tables. |
Right. |
FF 54.01 64bit
|
@englishextra Firefox 54 is obsolete and was superseded by 56; please always keep it current. |
Are you serious? It's of Jun 29, 2017
What? |
@englishextra, I certainly won't stop you from running old versions if you'd prefer, but it is generally unsafe to run browser versions older than the latest one (even ones that are only a few months old). You can see the known vulnerabilities fixed in version 55 here and version 56 here. Beyond that, let's please not hijack this thread anymore about this topic, folks. |
Hey, I'm doing webdev, and I know that regular users, that I'm writing sites for, use ancient browsers. I do have Nightly and the whole zoo of browsers. I gave an info as of FF 54 - which is in my case the benchmark version of FF. That's it and nothing alse more.
That's what I came here for, to make sure the sanitize error is not on my side as a web dev. |
Thanks a ton to all involved! |
I receive these errors in the console on my Windows 7 system using Firefox 54.0a2 (2017-04-26) (64-bit):
downloadable font: Layout: DFLT script doesn't satisfy the spec. DefaultLangSys is NULL (font-family: "Roboto" style:normal weight:normal stretch:normal src index:2) source: http://fonts.gstatic.com/s/roboto/v16/CWB0XYA8bzo0kSThX0UTuA.woff2 css:50:12
downloadable font: Layout: Failed to parse script table 0 (font-family: "Roboto" style:normal weight:normal stretch:normal src index:2) source: http://fonts.gstatic.com/s/roboto/v16/CWB0XYA8bzo0kSThX0UTuA.woff2 css:50:12
downloadable font: GSUB: Failed to parse script list table (font-family: "Roboto" style:normal weight:normal stretch:normal src index:2) source: http://fonts.gstatic.com/s/roboto/v16/CWB0XYA8bzo0kSThX0UTuA.woff2 css:50:12
downloadable font: rejected by sanitizer (font-family: "Roboto" style:normal weight:normal stretch:normal src index:2) source: http://fonts.gstatic.com/s/roboto/v16/CWB0XYA8bzo0kSThX0UTuA.woff2
This happens when
gfx.downloadable_fonts.otl_validation
is set to true (the default for Nightly but not stable releases)The text was updated successfully, but these errors were encountered: