Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inclusive Sans #5728

Closed
9 tasks done
LivKing opened this issue Dec 27, 2022 · 2 comments · Fixed by #6359
Closed
9 tasks done

Add Inclusive Sans #5728

LivKing opened this issue Dec 27, 2022 · 2 comments · Fixed by #6359
Assignees
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding
Milestone

Comments

@LivKing
Copy link

LivKing commented Dec 27, 2022

Font Project Git Repo URL:

Inclusive Sans is a text font designed for accessibility and readability. It incorporates key features at a character level to ensure legibility for all people.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com
  • The font supports at least GF Latin Core glyphset
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I read, agree and comply with the full contributing requirements
  • I am the author of the font or the author agreed to this submission
  • I will maintain the repository

Image:
InclusiveSans

Note
I've followed the repository and font file requirements as close as possible, but would appreciate help from a GF team member with the tooling and building process for my font.

@LivKing LivKing added I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels Dec 27, 2022
@RosaWagner
Copy link
Contributor

Hi @LivKing, thanks for your submission. It looks good and it is well documented. I added it to the submission to review with the rest of the team.

@RosaWagner RosaWagner added this to the Submissions to review milestone Mar 10, 2023
@RosaWagner RosaWagner added II Accepted Non-commissioned projects that are accepted for onboarding and removed II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels Mar 29, 2023
@RosaWagner RosaWagner assigned emmamarichal and unassigned yanone May 25, 2023
@emmamarichal emmamarichal moved this from Todo to In Progress in Google Fonts Jun 1, 2023
@emmamarichal
Copy link
Collaborator

Hi @LivKing,
Thanks for your nice project! I took a look to the file, and noticed that the glyphset doesn't follow the GF Latin Core glyphset (maybe it has been updated since December 2022).
Here are the missing glyphs:
less, greater, asciicircum, grave, asciitilde, section, dieresis, ordfeminine, guillemetleft, acute, paragraph, cedilla, ordmasculine, guillemetright, multiply, circumflex, caron, breve, dotaccent, ring, ogonek, tilde, hungarumlaut, minus, Cdotaccent, Gbreve, Gdotaccent, Hbar, IJ, Idotaccent, Scommaaccent, Germandbls, Tcommaaccent, Ubreve, cdotaccent, gbreve, gdotaccent, hbar, idotaccent, ij, scommaaccent, tcommaaccent, ubreve, nbspace, .notdef, periodcentered.loclCAT, periodcentered.loclCAT.case, guilsinglleft, guilsinglright

Capture d’écran 2023-06-01 à 14 18 23

Some of them are quick to generate, I usually can do it, but in that case, a lot of them need some design work (section, paragraph, Germandbls, etc.)
Also, we keep legacy accents (without "comb"), which are composites, so easy to generate.

Don't hesitate if you have any question :)
Thanks!

Attached, the last version of sources, with the missing glyphs added (pink one)
InclusiveSans.glyphs.zip

@emmamarichal emmamarichal added -- Upstream is working on it Designer is making changes in the upstream repo and removed - Ready for Review labels Jun 1, 2023
@emmamarichal emmamarichal moved this from In Progress to Todo in Google Fonts Jun 1, 2023
@emmamarichal emmamarichal moved this from Todo to PR Upstream in Google Fonts Jun 8, 2023
@emmamarichal emmamarichal removed the -- Upstream is working on it Designer is making changes in the upstream repo label Jun 8, 2023
@emmamarichal emmamarichal moved this from PR Upstream to PR GF in Google Fonts Jun 9, 2023
@emmamarichal emmamarichal moved this from PR GF to In Progress in Google Fonts Jun 14, 2023
@emmamarichal emmamarichal added the -- Upstream is working on it Designer is making changes in the upstream repo label Jun 14, 2023
@emmamarichal emmamarichal moved this from In Progress to PR Upstream in Google Fonts Jun 29, 2023
@chrissimpkins chrissimpkins modified the milestones: 2023 Q2, 2023 Q4 Jul 17, 2023
@github-project-automation github-project-automation bot moved this from PR Upstream to In Dev / PR Merged in Google Fonts Aug 29, 2023
@emmamarichal emmamarichal modified the milestones: 2023 Q4, 2023 Q3 Sep 7, 2023
@RosaWagner RosaWagner moved this from In Dev / PR Merged to In Sandbox in Google Fonts Sep 14, 2023
@RosaWagner RosaWagner moved this from In Sandbox to Live in Google Fonts Sep 15, 2023
@RosaWagner RosaWagner removed the -- Upstream is working on it Designer is making changes in the upstream repo label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding
Projects
Status: Live
Development

Successfully merging a pull request may close this issue.

5 participants