-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] Generated single entry point is not API compatible with flatbuffers 1.x #7448
Comments
So one important thing to consider is that build systems like bazel (and Blaze within Google) require that all generated files be known and explicitly stated in the build rules. So when we have |
See "outs" at https://bazel.build/reference/be/general#genrule_args. We wrap the So this is why having a single file makes it easy to work with. |
@dbaileychess you are misunderstanding. This issue is not about how or why a single file build is useful. It's about the entry point that you can use to create single file build. It does not produce something that is API compatible with what you got with flatbuffers 1.x and this issue and suggested solution is how to fix that. I'll rephrase the subject of this issue. |
This issue is stale because it has been open 6 months with no activity. Please comment or label |
I realize now #6673 was misguided because it disregards namespaces and hacks around that by renaming symbols. That creates an entry point with potentially far too many symbols and unexpected symbol renames.
What would be the correct design would be to generate an entry point per namespace and reexport from the parent. That would be equivalent to the nested namespaces that was handled as namespace objects in 1.x code generation and could be used to bundle up an 1.x API compatible single file code generation file.
The text was updated successfully, but these errors were encountered: