We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Following #5591 a regression, introduced by #5339, was detected when generating Union with imported members.
Union
Version: master - Linux
flatc --go --gen-object-api --gen-all --gen-mutable -o ./golang/ Example_fbb.fbs
Example_fbb.fbs:
include "./message/auth_messages.fbs"; namespace Example; union MsgType { Auth.ServerAuthReq } table Root { message:MsgType; } root_type Root;
auth_messages.fbs:
include "./data/common_data.fbs"; namespace Example.Auth; table ServerAuthReq{ selfType:Data.ServerType; }
common_data.fbs
namespace Example.Data; enum ServerType : uint8 { None = 0, DatabaseServer, WebServer, }
The output code in "MsgType.go" imports itself
package Example import ( "strconv" flatbuffers "github.com/google/flatbuffers/go" Example "Example" Example__Auth "Example/Auth" ) ....
This happens because GenNativeUnion is called before updating cur_name_space_ to the correct enum namespace which eventually is done at GenEnum.
GenNativeUnion
cur_name_space_
GenEnum
flatbuffers/src/idl_gen_go.cpp
Lines 84 to 90 in 32254b7
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Following #5591 a regression, introduced by #5339, was detected when generating
Union
with imported members.Version: master - Linux
Example_fbb.fbs:
auth_messages.fbs:
common_data.fbs
The output code in "MsgType.go" imports itself
This happens because
GenNativeUnion
is called before updatingcur_name_space_
to the correct enum namespace which eventually is done atGenEnum
.flatbuffers/src/idl_gen_go.cpp
Lines 84 to 90 in 32254b7
The text was updated successfully, but these errors were encountered: