Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutoff 0.25 test not passing for AlphaBlendModeTest.gltf #1572

Closed
cx20 opened this issue Aug 28, 2019 · 12 comments
Closed

Cutoff 0.25 test not passing for AlphaBlendModeTest.gltf #1572

cx20 opened this issue Aug 28, 2019 · 12 comments
Assignees
Labels
gltf Specific to glTF support

Comments

@cx20
Copy link

cx20 commented Aug 28, 2019

Describe the bug
I tried to display AlphaBlendModeTest.gltf with filament latest version.
However, it did not pass the Cutoff 0.25 test.

To Reproduce
filament latest version + AlphaBlendModeTest.gltf result

Expected behavior
image

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 Version 1903 (OS Build 18362.295)
  • GPU: Intel HD Graphics 520
  • Backend: ANGLE
  • Browser: Chrome 76
@prideout
Copy link
Contributor

prideout commented Aug 28, 2019

This is expected when MSAA is enabled. The glTF spec is ambiguous with respect to ALPHA_TO_COVERAGE:

KhronosGroup/glTF-Sample-Models#221

@prideout prideout self-assigned this Aug 28, 2019
@prideout prideout added the gltf Specific to glTF support label Aug 28, 2019
@cx20
Copy link
Author

cx20 commented Aug 28, 2019

Thank you for telling me that thread. I will look at it.

@romainguy
Copy link
Collaborator

This test now passes properly.

@cx20
Copy link
Author

cx20 commented Aug 10, 2020

@romainguy I tried the gltf-test sample again with the latest build of Filament. However, the Cutoff 0.25 test result was 0.50.

Filament latest version + AlphaBlendModeTest.gltf result:
image

Is it the wrong way to use it? It would be great to get some advice.

@romainguy
Copy link
Collaborator

Are you using our main branch?

Screen Shot 2020-08-10 at 4 20 27 PM

@cx20
Copy link
Author

cx20 commented Aug 10, 2020

Are you using our main branch?

Yes. I used the following build of the main branch to try the WebGL version of Filament.

image

@romainguy
Copy link
Collaborator

@prideout Any idea? My screenshot is from gltf_viewer (native, not WebGL)

@romainguy romainguy reopened this Aug 10, 2020
@prideout
Copy link
Contributor

There's nothing to do here on the Filament side. When MSAA is disabled, we "pass" the test. When it's enabled, the rendering is affected by how the browser and GPU implement ALPHA_TO_COVERAGE.

Note that other renderers may or may not enable ALPHA_TO_COVERAGE since this is unspecified in the glTF standard.

It looks like cx20 has MSAA enabled, and is using a browser or GPU that implements ALPHA_TO_COVERAGE strangely. Not a Filament bug.

@romainguy
Copy link
Collaborator

Ah right, because when I disable MSAA I get the following in native:

Screen Shot 2020-08-10 at 5 02 04 PM

With MSAA:

Screen Shot 2020-08-10 at 5 02 39 PM

So yeah looks like a browser issue. I guess we could always disable alpha to coverage for glTF but ugh…

@prideout
Copy link
Contributor

I don't think we should take any actions until Khronos resolves KhronosGroup/glTF#1668

@romainguy
Copy link
Collaborator

Not holding my breath :)

@prideout
Copy link
Contributor

prideout commented Nov 1, 2022

This bug is 3 yrs old, closing.

@prideout prideout closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gltf Specific to glTF support
Projects
None yet
Development

No branches or pull requests

3 participants