account for switch expressions in UnnecessaryParentheses check #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cushon
approved these changes
Aug 26, 2021
cushon
reviewed
Oct 1, 2021
| Tree parent = state.getPath().getParentPath().getLeaf(); | ||
| if (parent instanceof StatementTree) { | ||
| return NO_MATCH; | ||
| }else if (parent instanceof SwitchExpressionTree){ |
There was a problem hiding this comment.
I'm going to change this a bit when I merge the PR, because we want to avoid referencing SwitchExpressionTree because that class is only available in JDK >= 12, and we want to remain compatible with JDK 8 for now.
There was a problem hiding this comment.
Sounds Good. As long as you don't need anything else from me I'll let you take it from here.
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
Nov 8, 2021
resolves google#1647, resolves google#2506 PiperOrigin-RevId: 400246492 (cherry picked from commit 0a87805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1647