diff --git a/check_api/pom.xml b/check_api/pom.xml index e9ba7b7e15e3..3f28f8ce0501 100644 --- a/check_api/pom.xml +++ b/check_api/pom.xml @@ -51,7 +51,7 @@ - org.checkerframework + io.github.eisop dataflow-errorprone ${dataflow.version} diff --git a/check_api/src/main/java/com/google/errorprone/dataflow/nullnesspropagation/AbstractNullnessPropagationTransfer.java b/check_api/src/main/java/com/google/errorprone/dataflow/nullnesspropagation/AbstractNullnessPropagationTransfer.java index 64604ff842fc..19f5dbf30d1b 100644 --- a/check_api/src/main/java/com/google/errorprone/dataflow/nullnesspropagation/AbstractNullnessPropagationTransfer.java +++ b/check_api/src/main/java/com/google/errorprone/dataflow/nullnesspropagation/AbstractNullnessPropagationTransfer.java @@ -53,6 +53,7 @@ import org.checkerframework.errorprone.dataflow.cfg.node.DoubleLiteralNode; import org.checkerframework.errorprone.dataflow.cfg.node.EqualToNode; import org.checkerframework.errorprone.dataflow.cfg.node.ExplicitThisNode; +import org.checkerframework.errorprone.dataflow.cfg.node.ExpressionStatementNode; import org.checkerframework.errorprone.dataflow.cfg.node.FieldAccessNode; import org.checkerframework.errorprone.dataflow.cfg.node.FloatLiteralNode; import org.checkerframework.errorprone.dataflow.cfg.node.FloatingDivisionNode; @@ -1019,6 +1020,20 @@ Nullness visitClassDeclaration() { return NULLABLE; } + @Override + public final TransferResult> visitExpressionStatement( + ExpressionStatementNode node, TransferInput> input) { + /* + * The fact that something is an expression statement is presumably irrelevant to nullness. So + * probably no code looks at this result. And if the statement needs to update the store + * somehow, that gets handled by the other visit* methods. I think. + * + * See + * https://github.com/eisop/checker-framework/blob/7c5e731da5665cba0612e8c85287d380fd66e924/dataflow/src/main/java/org/checkerframework/dataflow/cfg/node/ExpressionStatementNode.java#L20 + */ + return noStoreChanges(NONNULL, input); + } + private static final class ReadableUpdates implements Updates { final Map values = new HashMap<>(); diff --git a/core/pom.xml b/core/pom.xml index c7676b6a53f6..a922b690eaa0 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -94,7 +94,7 @@ - org.checkerframework + io.github.eisop dataflow-errorprone ${dataflow.version} diff --git a/pom.xml b/pom.xml index 619b27e4d49e..e778c089e939 100644 --- a/pom.xml +++ b/pom.xml @@ -35,7 +35,7 @@ 1.0.1 1.9 4.13.2 - 3.27.0 + 3.34.0-eisop1 4.9.0 0.19 3.0.5 diff --git a/test_helpers/pom.xml b/test_helpers/pom.xml index 6d798ac870c7..702bb09c897c 100644 --- a/test_helpers/pom.xml +++ b/test_helpers/pom.xml @@ -57,7 +57,7 @@ - org.checkerframework + io.github.eisop dataflow-errorprone ${dataflow.version}