Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect auto margins on RTL languages #829

Closed
Tracked by #1442
chen-shmilovich-sysdig opened this issue Jan 13, 2022 · 1 comment · Fixed by #2018
Closed
Tracked by #1442

Incorrect auto margins on RTL languages #829

chen-shmilovich-sysdig opened this issue Jan 13, 2022 · 1 comment · Fixed by #2018
Labels
i18n Internationalization / Localization

Comments

@chen-shmilovich-sysdig
Copy link

chen-shmilovich-sysdig commented Jan 13, 2022

In assets/scss/rtl/_spacing.scss:

.mr#{$infix}-auto,
.mx#{$infix}-auto {
    margin-right: auto !important;
}

mr-auto should set an auto left margin on RTL languages.

and

.ml#{$infix}-auto,
.mx#{$infix}-auto {
    margin-left: auto !important;
}

ml-auto should set an auto right margin on RTL languages.

In the example site you can that it affects the navbar when switching to an RTL language:
image

The nav items should float to the left but the navbar still has an auto margin-left, so it stays in place.

@ShlokJswl
Copy link

Hello can you please assign this issue to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization / Localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants