Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] Footer icon-group placement and spacing issues #2005

Closed
Tracked by #1442
chalin opened this issue May 16, 2024 · 2 comments
Closed
Tracked by #1442

[RTL] Footer icon-group placement and spacing issues #2005

chalin opened this issue May 16, 2024 · 2 comments
Labels
i18n Internationalization / Localization
Milestone
24Q4

Comments

@chalin
Copy link
Collaborator

chalin commented May 16, 2024 •
edited
Loading

In an RTL page:

  • The left-side icon group isn't left-aligned
  • The spacing between icons in the right-side icon group is a bit off for the last icon

... as illustrated in the following screenshot:

image
@chalin chalin added this to the 24Q2 milestone May 16, 2024
@chalin chalin mentioned this issue May 16, 2024
Closed
22 tasks
@chalin chalin changed the title [RTL] Footer issue [RTL] Footer icon-group placement and spacing issues May 16, 2024
@chalin chalin added the i18n Internationalization / Localization label May 17, 2024
@chalin
Copy link
Collaborator Author

chalin commented May 29, 2024

Another example: from https://example.docsy.dev/fa/docs/. Note the spacing and location of the footer icons:

image

@chalin chalin modified the milestones: 24Q2, 24Q3 Jul 2, 2024
@chalin chalin modified the milestones: 24Q3, 24Q4 Oct 3, 2024
@chalin chalin mentioned this issue Oct 10, 2024
Merged
@chalin
Copy link
Collaborator Author

chalin commented Oct 10, 2024

Fixed via:

As confirmed via:

@chalin chalin closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n Internationalization / Localization
Projects
None yet
Milestone
24Q4
Development

No branches or pull requests
1 participant
@chalin