-
Notifications
You must be signed in to change notification settings - Fork 124
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up naming in clif/python/gen.py (functional no-op).
Preparation for cl/558051567. The existing naming is prone to lead to misunderstandings in the review of cl/558051567. Renaming overview (see https://docs.python.org/3/c-api/typeobj.html): ``` PyTypeObject PyCLIF C++ function names “tp slots” Old New tp_init _ctor tp_init_impl tp_alloc _new tp_alloc_impl tp_dealloc _dtor tp_dealloc_impl tp_free _del tp_free_impl ``` Notes: * cl/558051567 introduces `tp_new_impl` for the `tp_new` slot. * The removal of class_test.py with cl/557905637 made this CL much easier. * The TGP (link below) for this CL is extremely noisy, despite several fresh attempts and reruns. See https://yaqs.corp.google.com/eng/q/7353860321519337472#a1n3 for how the risk of missing new failures was mitigated. PiperOrigin-RevId: 558429410
- Loading branch information
rwgk
committed
Aug 29, 2023
1 parent
7501b3c
commit 2884d42
Showing
1 changed file
with
30 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters