Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEL proto test of 0.0 vs -0.0 does not hold for all proto implementations #198

Closed
jsannemo opened this issue Jun 12, 2021 · 1 comment
Closed

CEL proto test of 0.0 vs -0.0 does not hold for all proto implementations #198

jsannemo opened this issue Jun 12, 2021 · 1 comment

Comments

@jsannemo
Copy link
Contributor

The test field_assign_proto3_round_to_zero checks that the float -0.0 is sent back. Distinguishing between this and 0.0 is, as far as I know, not something that the proto serializers of all languages do (for example, see Java: protocolbuffers/protobuf#7062).
@TristonianJones TristonianJones mentioned this issue Sep 21, 2021
Closed
@TristonianJones
Copy link
Collaborator

Looks like this is a bug in proto that will be fixed in upcoming releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove test for negative zero, inconsistent behavior on Java, C++, and Go TristonianJones/cel-spec
2 participants
@TristonianJones @jsannemo