From c7780ccd7aeff2eb087455bd161ab0f482ba6e9b Mon Sep 17 00:00:00 2001 From: Christopher Allen Date: Wed, 21 Jun 2023 20:21:57 +0100 Subject: [PATCH] fix(blocks): Mark previously-@private methods @internal Where certain block mixin methods had been marked @private, and these annotations had been deleted while migrating the containing files to TypeScript, mark those methods as @internal. --- blocks/logic.ts | 2 ++ blocks/text.ts | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/blocks/logic.ts b/blocks/logic.ts index f1fd4c70f5a..6996d1721b6 100644 --- a/blocks/logic.ts +++ b/blocks/logic.ts @@ -505,6 +505,8 @@ const CONTROLS_IF_MUTATOR_MIXIN = { }, /** * Modify this block to have the correct number of inputs. + * + * @internal */ updateShape_: function (this: IfBlock) { // Delete everything. diff --git a/blocks/text.ts b/blocks/text.ts index 37e09b714a7..0ce745d14e2 100644 --- a/blocks/text.ts +++ b/blocks/text.ts @@ -297,6 +297,7 @@ const GET_SUBSTRING_BLOCK = { * Create or delete an input for a numeric index. * This block has two such inputs, independent of each other. * + * @internal * @param n Which input to modify (either 1 or 2). * @param isAt True if the input includes a value connection, false otherwise. */ @@ -445,6 +446,7 @@ const PROMPT_COMMON = { /** * Modify this block to have the correct output type. * + * @internal * @param newOp The new output type. Should be either 'TEXT' or 'NUMBER'. */ updateType_: function (this: PromptCommonBlock, newOp: string) { @@ -857,6 +859,7 @@ const JOIN_MUTATOR_MIXIN = { }, /** * Modify this block to have the correct number of inputs. + * */ updateShape_: function (this: JoinMutatorBlock) { if (this.itemCount_ && this.getInput('EMPTY')) { @@ -955,6 +958,7 @@ const CHARAT_MUTATOR_MIXIN = { /** * Create or delete an input for the numeric index. * + * @internal * @param isAt True if the input should exist. */ updateAt_: function (this: CharAtBlock, isAt: boolean) {