Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in nrf52840_dongle_dfu board #351

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix typo in nrf52840_dongle_dfu board #351

merged 1 commit into from
Aug 2, 2021

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Jul 29, 2021

Fixes #348. Introduced by #334.

Tested with:

./reset.sh
./setup.sh
./deploy.py --board=nrf52840_dongle_dfu --programmer=nordicdfu --erase_storage
./deploy.py --board=nrf52840_dongle_dfu --programmer=nordicdfu --opensk
# No panic and works on webauthn.io

@ia0
Fix google#348
8ba5c07 
The dongle_dfu board should copy the dongle_opensk board and not the dongle
board. This issue was introduced by google#334.
@ia0 ia0 requested a review from kaczmarczyck July 29, 2021 21:31
@google-cla google-cla bot added the cla: yes label Jul 29, 2021
@ia0 ia0 mentioned this pull request Jul 29, 2021
Open
@jmichelp jmichelp merged commit 14115fb into google:develop Aug 2, 2021
@ia0 ia0 deleted the fix_348 branch August 2, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaczmarczyck kaczmarczyck kaczmarczyck approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ia0 @kaczmarczyck @jmichelp