From 111159794bff3fd041ac5c94334cf35cbf2aeeb9 Mon Sep 17 00:00:00 2001 From: Seth Vargo Date: Wed, 13 Dec 2023 10:29:10 -0500 Subject: [PATCH] Update README and CI to use latest version (#289) --- .github/workflows/integration.yml | 4 ++-- .github/workflows/unit.yml | 2 +- README.md | 36 +++++++------------------------ 3 files changed, 11 insertions(+), 31 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 25ad802..189f9f7 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -33,7 +33,7 @@ jobs: - name: 'npm build' run: 'npm ci && npm run build' - - uses: 'google-github-actions/auth@main' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' @@ -62,7 +62,7 @@ jobs: - name: 'npm build' run: 'npm ci && npm run build' - - uses: 'google-github-actions/auth@main' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml index 57009e9..6927943 100644 --- a/.github/workflows/unit.yml +++ b/.github/workflows/unit.yml @@ -46,7 +46,7 @@ jobs: if: ${{ matrix.os == 'ubuntu-latest' }} run: 'npm run lint' - - uses: 'google-github-actions/auth@main' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' diff --git a/README.md b/README.md index 25c017a..8031c89 100644 --- a/README.md +++ b/README.md @@ -42,13 +42,13 @@ jobs: steps: - id: 'auth' - uses: 'google-github-actions/auth@v1' + uses: 'google-github-actions/auth@v2' with: workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider' service_account: 'my-service-account@my-project.iam.gserviceaccount.com' - id: 'get-credentials' - uses: 'google-github-actions/get-gke-credentials@v1' + uses: 'google-github-actions/get-gke-credentials@v2' with: cluster_name: 'my-cluster' location: 'us-central1-a' @@ -134,13 +134,13 @@ jobs: steps: - id: 'auth' - uses: 'google-github-actions/auth@v1' + uses: 'google-github-actions/auth@v2' with: workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider' service_account: 'my-service-account@my-project.iam.gserviceaccount.com' - id: 'get-credentials' - uses: 'google-github-actions/get-gke-credentials@v1' + uses: 'google-github-actions/get-gke-credentials@v2' with: cluster_name: 'my-cluster' location: 'us-central1-a' @@ -153,12 +153,12 @@ jobs: job_id: steps: - id: 'auth' - uses: 'google-github-actions/auth@v1' + uses: 'google-github-actions/auth@v2' with: credentials_json: '${{ secrets.gcp_credentials }}' - id: 'get-credentials' - uses: 'google-github-actions/get-gke-credentials@v1' + uses: 'google-github-actions/get-gke-credentials@v2' with: cluster_name: 'my-cluster' location: 'us-central1-a' @@ -176,7 +176,7 @@ jobs: job_id: steps: - id: 'get-credentials' - uses: 'google-github-actions/get-gke-credentials@v1' + uses: 'google-github-actions/get-gke-credentials@v2' with: cluster_name: 'my-cluster' location: 'us-central1-a' @@ -196,7 +196,7 @@ jobs: job_id: steps: - id: 'get-credentials' - uses: 'google-github-actions/get-gke-credentials@v1' + uses: 'google-github-actions/get-gke-credentials@v2' with: cluster_name: 'my-private-cluster' location: 'us-central1-a' @@ -206,26 +206,6 @@ jobs: Follow the [Connect gateway documentation][connect-gw] for initial setup. Note: The Connect Agent service account must have the correct [impersonation policy][connect-gw-impersonation] on the service account used to authenticate this action. -## Versioning - -We recommend pinning to the latest available major version: - -```yaml -- uses: 'google-github-actions/get-gke-credentials@v1' -``` - -While this action attempts to follow semantic versioning, but we're ultimately -human and sometimes make mistakes. To prevent accidental breaking changes, you -can also pin to a specific version: - -```yaml -- uses: 'google-github-actions/get-gke-credentials@v1.0.0' -``` - -However, you will not get automatic security updates or new features without -explicitly updating your version number. Note that we only publish `MAJOR` and -`MAJOR.MINOR.PATCH` versions. There is **not** a floating alias for -`MAJOR.MINOR`. [gke]: https://cloud.google.com/kubernetes-engine [gcp-auth-plugin]: https://github.com/kubernetes/client-go/tree/master/plugin/pkg/client/auth/gcp