Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a long term pattern for reuse between this implementation and the vertex AI SDK #111

Open
natebosch opened this issue Apr 3, 2024 · 1 comment
Labels
component:dart sdk Issue/PR related to Dart SDK status:triaged Issue/PR triaged to the corresponding sub-team type:feature request A request for a change that isn't a bug

Comments

@natebosch
Copy link
Collaborator

There is a lot of overlap between the services, so initially the vertex AI SDK will depend on this package for most data types and the base model implementation. We'll start out with lib/src/ imports from the vertex AI SDK and extra caution when making changes here. When we are getting ready to publish as a stable version we should move to a better long term approach, or add mechanical checks to the current approach. In my opinion we should choose between making the extension points part of the stable public API, or moving the base implementation to a shared dependency and using the same customization handles to implement the vertex and google AI SDKs, or moving both implementations into a single package.

@singhniraj08 singhniraj08 added type:feature request A request for a change that isn't a bug component:dart sdk Issue/PR related to Dart SDK status:triaged Issue/PR triaged to the corresponding sub-team and removed package:google_generative_ai labels Apr 4, 2024
@davidmigloz
Copy link
Contributor

Is there any reason why the package doesn't expose the ability to override the base URL and add custom headers? It's common practice to call LLM APIs through a proxy server to avoid hardcoding the API keys into the client apps. Currently, the only way to do this seems to be to provide a custom HTTP client that overrides the base URL and add the custom headers behind the scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:dart sdk Issue/PR related to Dart SDK status:triaged Issue/PR triaged to the corresponding sub-team type:feature request A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants