Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax numpy version requirement #110

Closed
wookayin opened this issue Nov 3, 2022 · 2 comments
Closed

Relax numpy version requirement #110

wookayin opened this issue Nov 3, 2022 · 2 comments

Comments

@wookayin
Copy link

wookayin commented Nov 3, 2022

1e2e4bc introduced version qualifier numpy < 1.23 due to failing tests with jax, but I believe this has been resolved with recent jax versions and we no longer need < 1.23.

I could write a trivial PR that fixes requirements.txt, but let me leave it to be handled by the rlax team because the commit does not specify at which jax version tests are failing, hopefully the CL can update jax and numpy version requirements.

/cc @katebaumli
@KaleabTessera
Copy link

This would important to fix since now you can't rlax with newer versions of jax or numpy.

@katebaumli
Copy link
Collaborator

Apologies for the delay. This should be fixed by #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wookayin @KaleabTessera @katebaumli