Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang++ 15.0 compiler issue with spiel_utils #1295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

giogix2
Copy link
Contributor

@giogix2 giogix2 commented Dec 2, 2024

This PR fixes one of the issues reported in #1293.
The compiler fails when building the Dockerfile.base. Specifically, the issue occurs when the compiler Clang++ 15.0.0 is used (Note: no other compilers were tested, so it's unclear if the issue happens with other compilers or settings).

The error looks as the following

3.450 In file included from /repo/open_spiel/spiel_utils.cc:15:
3.452 /repo/open_spiel/../open_spiel/spiel_utils.h:51:59: error: no template named 'unique_ptr' in namespace 'std'
3.452 std::ostream& operator<<(std::ostream& stream, const std::unique_ptr<T>& v);
3.452                                                      ~~~~~^
3.463 /repo/open_spiel/../open_spiel/spiel_utils.h:88:59: error: no template named 'unique_ptr' in namespace 'std'
3.463 std::ostream& operator<<(std::ostream& stream, const std::unique_ptr<T>& v) {

and it can be fixed by explicitly importing the library memory in spiel_utils.h.

@lanctot
Copy link
Collaborator

lanctot commented Dec 4, 2024

Thanks!!

@lanctot
Copy link
Collaborator

lanctot commented Dec 5, 2024

Same here please: Can you pull changes from master and push the merge commit to trigger the CI tests again?

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants