Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CIS-DI-0009's level from FATAL to WARN #218

Open
dyferx opened this issue Feb 9, 2023 · 3 comments
Open

Change CIS-DI-0009's level from FATAL to WARN #218

dyferx opened this issue Feb 9, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dyferx
Copy link

dyferx commented Feb 9, 2023

We have Gitlab CICD pipeline where we are building our docker images. One of the job in the workflow is Dockle scans. When vulnerability with status Fatal is found, pipeline stops and image is not pushed to the registry.

In my Dockerfiles i'm using ADD command to download software into the image, for example:

ADD https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_linux_amd64.zip ./

Dockle finds FATAL vulnerability: CIS-DI-0009 and this breaks our pipelines.

In my opinion CIS-DI-0009 shouldn't have FATAL status. We can use wget or curl instead, but then we need wget or curl inside the image, what is increasing image size. Downloading software from internet using wget or curl has the same security level like ADD and for Dockle this is not FATAL vulnerability.

Description for CIS-DI-0009 is as following:
ADD instruction introduces risks such as adding malicious files from URLs without scanning and unpacking procedure vulnerabilities.

If my understanding is right, this makes not much sense in Dockle because source for dockle is docker image not dockerfile, so we have downloaded files inside the image.

@dyferx dyferx added the bug Something isn't working label Feb 9, 2023
@dyferx dyferx changed the title CIS-DI-0009 DO we really need it? CIS-DI-0009 Do we really need it? Feb 9, 2023
@dyferx dyferx changed the title CIS-DI-0009 Do we really need it? CIS-DI-0009 Shouldn't have FATAL status Feb 9, 2023
@tomoyamachi
Copy link
Collaborator

Thank you for your recommendation.
I'll think about it.

@tomoyamachi tomoyamachi added enhancement New feature or request and removed bug Something isn't working labels Feb 12, 2023
@tomoyamachi tomoyamachi changed the title CIS-DI-0009 Shouldn't have FATAL status Change CIS-DI-0009's level from FATAL to WARN Feb 12, 2023
@tomoyamachi tomoyamachi self-assigned this Feb 12, 2023
@jorgelc
Copy link

jorgelc commented Mar 22, 2023

I would like to upvote this. For my team, dockle is flagging ADD statements from an upstream image, so it is not even in our control to change that behaviour.

@andrealmar
Copy link

+1 on that. Dockle is breaking our pipelines raising a FATAL because we are using an official ubuntu:latest image and this image has the ADD instruction: https://hub.docker.com/layers/library/ubuntu/mantic/images/sha256-3853398d8cefdc1c02ca82cd809ab3ab3851728da0de68325389b7e53eb26acd?context=explore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants