Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop alerting /tmp as suspicious directory (DKL-LI-0003) #215

Closed
zfLQ2qx2 opened this issue Jan 11, 2023 · 4 comments
Closed

Stop alerting /tmp as suspicious directory (DKL-LI-0003) #215

zfLQ2qx2 opened this issue Jan 11, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@zfLQ2qx2
Copy link

Description

Dockle 0.4.10 is reporting /tmp as a suspicious directory:

INFO    - DKL-LI-0003: Only put necessary files
--
400 | * unnecessary file : usr/local/share/.cache/yarn/v6/npm-@pm2-io-5.0.0-623cbcaf6fe39375f20ac2e75497477a1b1ec5c5-integrity/node_modules/@pm2/io/docker-compose.yml
401 | * Suspicious directory : tmp

What did you expect to happen?

It makes sense to remove any files in /tmp as part of the container build process, however the /tmp directory itself should always exist in a unix system, there are too many things including system functions that expect that directory to exist. Our developers had started to remove the /tmp directory to appease Dockle which caused issues when the containers tried to start.

What happened instead?

Dockle 0.4.10 reports /tmp as DKL-LI-0003 suspicious directory

@zfLQ2qx2 zfLQ2qx2 added the bug Something isn't working label Jan 11, 2023
@tomoyamachi
Copy link
Collaborator

Thank you for your recommendation.
I'll think about it.

@tomoyamachi tomoyamachi changed the title Dockle 0.4.10 reports /tmp as DKL-LI-0003 suspicious directory Stop alerting /tmp as suspicious directory (DKL-LI-0003) Feb 12, 2023
@tomoyamachi tomoyamachi self-assigned this Feb 12, 2023
@RoseSecurity
Copy link
Contributor

@tomoyamachi Hey! Just opened a PR to address this ticket. Feel free to check it out if you have an opportunity.

@tomoyamachi
Copy link
Collaborator

@RoseSecurity Thank you for your contribution.
Your code has been included in the latest release.

@RoseSecurity
Copy link
Contributor

@RoseSecurity Thank you for your contribution.

Your code has been included in the latest release.

If you ever need help maintaining, just say the word!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants