Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the proxy redirect to an upstream download protocol (i.e. Olympus) with HTTP 301s #495

Closed
arschles opened this issue Aug 16, 2018 · 7 comments
Assignees
Labels
proxy Work to do on the module proxy

Comments

@arschles
Copy link
Member

arschles commented Aug 16, 2018

We voted in #423 (comment) to make the proxy issue HTTP 301 redirects to the CLI when the proxy datastore doesn't have the given module@version.

Note that we're going to do this for our first released version. We can add local caching/storage after that.

@arschles arschles added the proxy Work to do on the module proxy label Aug 16, 2018
@arschles
Copy link
Member Author

Also, this means that if you make the proxy "exclude" all modules in its exclude list, then it will act as if there is no upstream, fetch everything from the VCS (using go get on the backend), and store it all in its datastore.

@marwan-at-work
Copy link
Contributor

@arschles did you mean "include" all modules? "excluding" all modules would return status forbidden.

@michalpristas
Copy link
Member

exclude should break the communication.
Include goes upstream (whatever it is, for proxy its olympus, for olympus it's VCS)
direct goes to VCS without caring about upstream

@fedepaol
Copy link
Member

Can I take this one?

@michalpristas
Copy link
Member

This was discussed as post-MVP but sure @fedepaol

@michalpristas
Copy link
Member

@marwan-at-work you self-assigned this few days ago, are you ok with @fedepaol working on this?

@marwan-at-work
Copy link
Contributor

This is already done through the filter middleware and the global switch. Will close the issue and open a new one for cache filling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy Work to do on the module proxy
Projects
None yet
Development

No branches or pull requests

4 participants