Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring readiness probe through values #95

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

Thor77
Copy link
Contributor

@Thor77 Thor77 commented Nov 12, 2024

Use readiness probe parameters from values.
In some cases it's required to adjust the default probe parameters and currently this is only possible for the liveness probe.

@Thor77 Thor77 requested a review from a team as a code owner November 12, 2024 13:53
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrPsychick
Copy link
Member

DrPsychick commented Nov 13, 2024

Thank you @Thor77 for your contribution, if you want you can bump the chart patch version in Chart.yaml so it creates a release when merged.

@Thor77
Copy link
Contributor Author

Thor77 commented Nov 14, 2024

@DrPsychick you're welcome! I added a commit to bump the chart version

@DrPsychick DrPsychick merged commit 590014a into gomods:main Nov 14, 2024
1 check passed
@Thor77 Thor77 deleted the readinessprobe-values branch November 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants