Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @types/convict to allow nullable option #52

Open
kchow1985 opened this issue May 17, 2023 · 3 comments
Open

update @types/convict to allow nullable option #52

kchow1985 opened this issue May 17, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kchow1985
Copy link

The current @types/convict version does not allow you to specify the nullable option for config values.

i.e.

type ConfigOptions {
  valueA: string
}

export default createProfiguration<ConfigOptions>({
  valueA: {
    format: String,
    env: 'SOME_CONFIG_VALUE',
    default: null,
    nullable: true // typescript will complain because v5.2.0 @types/convict definition does not define this property
});

The convict version on the package is ^6.0.0 which would be 6.2.4 if downloaded from npm, but @types/convict is 5.2.0 which should be updated to 6.1.1

@underfisk
Copy link
Collaborator

@kchow1985 Feel free to create a PR with those updates and I'll happily review and merge

@underfisk underfisk added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2023
@MickL
Copy link
Contributor

MickL commented Oct 20, 2023

I agree @kchow1985 could have immediatley created a PR, but I wonder if this module is not maintained anymore?

@underfisk
Copy link
Collaborator

I agree @kchow1985 could have immediatley created a PR, but I wonder if this module is not maintained anymore?

Hi @MickL, I've been actively looking at new issues and any security-patch but unfortunately, I don't have enough capacity to contribute and develop more features. I believe there are some alternatives to just using zod; the project was left as is with a stable API.
It doesn't mean that any new contribution is not properly reviewed and merged, it just means that the authors as of now are not looking to develop any other feature to the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants