Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service instance remains in whatever state it was on an exception #666

Closed
shadeofblue opened this issue Sep 17, 2021 · 0 comments · Fixed by #700
Closed

Service instance remains in whatever state it was on an exception #666

shadeofblue opened this issue Sep 17, 2021 · 0 comments · Fixed by #700
Assignees
Labels
beta.3.patch.1 bug Something isn't working

Comments

@shadeofblue
Copy link
Contributor

Description

OS: any
[ e.g. Ubuntu 18.04, Windows 10, etc ]

yapapi library version: 0.7.0dev

Description of the issue:
When an error occurs on an Service instance, the state of the instance remains what it was, e.g. running or starting instead of being transitioned to terminated

Actual result:

[2021-09-17T13:08:41.590+0200 INFO yapapi.summary] [Job 1] Task started on provider 'EBGolem-1', task data: Service: SimpleService
[2021-09-17T13:08:41.882+0200 INFO yapapi.summary] [Job 1] Terminated agreement with EBGolem-1
[2021-09-17T13:08:43.289+0200 INFO yapapi.summary] [Job 1] Accepted invoice from 'EBGolem-1', amount: 0
instances: ['simple-service-1: starting on EBGolem-1']

Steps To Reproduce

  1. introduce an error in the Service code, e.g.
SomeService(Service):
    async def start():
        pass
  1. run a script that launches that service with Golem.run_service
  2. observe the behavior -> the Service instance remains started despite a clear indication of termination of the activity

Expected behavior

The service should be marked terminated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta.3.patch.1 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants