Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immediately stopped cluster will still start instances #461

Closed
johny-b opened this issue Jun 11, 2021 · 3 comments · Fixed by #699
Closed

immediately stopped cluster will still start instances #461

johny-b opened this issue Jun 11, 2021 · 3 comments · Fixed by #699
Assignees
Labels

Comments

@johny-b
Copy link
Contributor

johny-b commented Jun 11, 2021

Cluster object is available before instances are created.
Cluster.stop() does nothing except for stopping current instances.

So if we do this:

cluster = await golem.run_service(...)
cluster.stop()

instances will still be created and another cluster.stop() will be required later to stop them.

IMHO the smallest necessary change would be to rename stop() to stop_current_instances() or something like that (but I'm not saying this is the best solution).

@johny-b johny-b changed the title immediately stopped cluster will still started instances immediately stopped cluster will still start instances Jun 11, 2021
@mateuszsrebrny
Copy link
Contributor

mateuszsrebrny commented Jun 30, 2021

Leaving in backlog, but we still need to define how this should work

@mateuszsrebrny
Copy link
Contributor

not sure if this is for this patch.3 - just labelling not to forget

@johny-b
Copy link
Contributor Author

johny-b commented Aug 12, 2021

@shadeofblue Could you explain why this is in the Icebox? This seems pretty important to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants