Agreement should be terminated after activity fails

[azawlocki]

Currently an agreement is reused after

• activity creation fails, e.g. due to timeout error (HTTP 408)
• there's an error after an activity is created, either in the user's code in the worker function, an API error occurs or a command fails on the provider

In both cases, the agreement should be terminated.

It's probably also a good idea to take this into the account when scoring new offers from the same provider.

EDIT: Added a log from blender.py run in which an agreement is created with a faulty provider for which every attempt to create an activity ends with a TimeoutError. The agreement is reused and the requestor repeatedly tries to create an activity on this provider.
blender-yapapi-reusing-bad-agreement.log.gz

[tworec]

It's probably also a good idea to take this into the account when scoring new offers from the same provider.

Do you mean "local reputation" ? 👍

[azawlocki]

@nieznanysprawiciel 's idea: distinguish "provider errors" (e.g. timeout when creating activity) and "command errors" when deciding whether to terminate agreement (or give the provider a second chance).

[shadeofblue]

It's probably also a good idea to take this into the account when scoring new offers from the same provider.

Do you mean "local reputation" ? 👍

more like run-local ;)

[shadeofblue]

@azawlocki anyway, is this done or does it need more love?

[azawlocki]

Resolved by #294