Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goth failure after ya-relay update #2760

Closed
pwalski opened this issue Sep 19, 2023 · 7 comments · Fixed by #2840
Closed

Goth failure after ya-relay update #2760

pwalski opened this issue Sep 19, 2023 · 7 comments · Fixed by #2840
Assignees
@pwalski

Comments

@pwalski
Copy link
Contributor

pwalski commented Sep 19, 2023 •
edited
Loading

The goal is to fix goth test failures
https://github.com/golemfactory/yagna/actions/runs/6223519320/job/16890700484?pr=2614
@pwalski pwalski self-assigned this Sep 19, 2023
@pwalski
Copy link
Contributor Author

pwalski commented Sep 21, 2023

(I updated goth_tests README to describe how to run it locally using yagna sources to not need to figure it out ever again https://github.com/golemfactory/yagna/blob/pwalski/goth_tests_readme/goth_tests/README.md.
I see we have now a new goth2 runner, and goth itself has some payment module related changes. No idea what to do with it 🤷)

@pwalski
Copy link
Contributor Author

pwalski commented Sep 26, 2023

I do not know if it is the only problem, but latest goth version ignores ya-relay version override:
INFO [goth.runner.download ] Using cached release. cache_path=/tmp/goth_asset_cache/98864650/ya_relay_server_v0.2.2_amd64.deb

@pwalski
Copy link
Contributor Author

pwalski commented Sep 26, 2023

https://github.com/golemfactory/goth/blob/c666e43399aee64c926077c868de7adc89d9d902/goth/configuration.py#L352C13-L352C13 Need to do dpath.util.merge instead of .new, but merge fails.

@pwalski
Copy link
Contributor Author

pwalski commented Sep 28, 2023 •
edited
Loading

I fixed goth tests config, but some of tests are failing https://github.com/golemfactory/yagna/actions/runs/6330525128/job/17197333283

@pwalski
Copy link
Contributor Author

pwalski commented Oct 3, 2023

p2p_stability needs this changes to work #2809 which needs this PR #2812 to not exceed GH API quota

@pwalski
Copy link
Contributor Author

pwalski commented Oct 4, 2023

CI on p2p-stability should pass now #2614

@pwalski pwalski closed this as completed Oct 4, 2023
@pwalski
Copy link
Contributor Author

pwalski commented Oct 4, 2023

It failed..

@pwalski pwalski reopened this Oct 4, 2023
@pwalski pwalski linked a pull request Oct 16, 2023 that will close this issue
revert smoltcp to old version #2840
Merged
@jalas167 jalas167 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwalski pwalski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert smoltcp to old version golemfactory/yagna
2 participants
@pwalski @jalas167