Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there's no way to pass environment variables to the run command #2448

Open
shadeofblue opened this issue Feb 2, 2023 · 4 comments
Open

there's no way to pass environment variables to the run command #2448

shadeofblue opened this issue Feb 2, 2023 · 4 comments
Assignees
Labels
sdk-request issue requested by SDK team

Comments

@shadeofblue
Copy link
Contributor

as exemplified in https://github.com/golemfactory/yapapi/pull/1100/files

@nieznanysprawiciel
Copy link
Contributor

ExeUnit doesn't support this syntax at this moment.
I can't see this in ya-client-model or any specification, so it wasn't planned before.
But I don't see any obvious reasons, why this feature couldn't be implemented.

@kamirr
Copy link
Contributor

kamirr commented Mar 1, 2023

No feedback, closing. If you do need this feature, please reopen.

@kamirr kamirr closed this as completed Mar 1, 2023
@shadeofblue
Copy link
Contributor Author

shadeofblue commented Mar 16, 2023

I don't really get the no feedback note above ... the SDK team has already specified this as something worth pursuing, what other kind of feedback do you need?

@shadeofblue shadeofblue reopened this Mar 16, 2023
@shadeofblue shadeofblue added the sdk-request issue requested by SDK team label Mar 16, 2023
@jalas167
Copy link
Contributor

jalas167 commented Apr 3, 2023

Note: there is a way to pass variables for a command i.e. ['/bin/sh/', '-c', 'ENV_VAL=value command'],
the way variable is set depends on the shell

the issue is about to add support for passing env variables as an additional param to the run command like in docker,

@kamirr kamirr self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk-request issue requested by SDK team
Projects
None yet
Development

No branches or pull requests

4 participants