Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET - repeat protocol messages #1872

Closed
nieznanysprawiciel opened this issue Mar 9, 2022 · 2 comments · Fixed by golemfactory/ya-relay#218 or #2263
Closed

NET - repeat protocol messages #1872

nieznanysprawiciel opened this issue Mar 9, 2022 · 2 comments · Fixed by golemfactory/ya-relay#218 or #2263
Assignees
@kamirr
Labels
hybrid-net

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented Mar 9, 2022 •
edited
Loading

Why:

  • UDP messages don't have to reach destination, so we need to repeat them

What:

  • If there is no response / confirmation, send the same protocol message N times with the same request_id and timeout
  • Example: if we have get_node call that timeouts in 3 seconds, we should:
    • Split timeout into N timespans
    • Send message on the beginning of each timespan (for N=4, 0s, 0.75s, 1.5s, 2.25s)
    • If we get more than one response message, we should ignore duplicates
@nieznanysprawiciel
Copy link
Contributor Author

related to: golemfactory/ya-relay#191

@nieznanysprawiciel
Copy link
Contributor Author

nieznanysprawiciel commented Oct 4, 2022 •
edited
Loading

Could solve: golemfactory/ya-relay#197

@kamirr kamirr self-assigned this Oct 13, 2022
@kamirr kamirr mentioned this issue Oct 18, 2022
Merged
@kamirr kamirr linked a pull request Oct 18, 2022 that will close this issue
ya-relay: repeat protocol messages (6e2c558) #2263
Merged
2 tasks
@kamirr kamirr reopened this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamirr kamirr

Labels
hybrid-net
Projects
None yet
Milestone
No milestone
2 participants
@kamirr @nieznanysprawiciel