Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LocalHeadCommandRunner.rsync_(up|down)() #4

Closed
Tracked by #2
johny-b opened this issue Apr 27, 2023 · 1 comment
Closed
Tracked by #2

Implement LocalHeadCommandRunner.rsync_(up|down)() #4

johny-b opened this issue Apr 27, 2023 · 1 comment

Comments

@johny-b
Copy link
Contributor

johny-b commented Apr 27, 2023

rsync_up/rsync_down sends files from the local machine to remote head.

In our case this is the same machine, so this doesn't-really-make-that-much sense, but we must nevertheless implement it.
Current idea:

  • Have some special directory. It's TBD where this directory should be created. Maybe we can have a subdir somewhere in /tmp/ray_*, where ray holds all the stuff? Or use appdirs?
  • rsync_up copies files to this directory, rsync_down copies from this directory.

So, we have a local directory we pretend is "remote".
BUT: we should start with learning when is rsync_up and rsync_down used internally by ray. E.g. if ray transfers some files this way, we must ensure it knows later how to use them.

@mateuszsrebrny
Copy link
Contributor

cleaning issues (issue no longer needed)

@mateuszsrebrny mateuszsrebrny closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants