Merge data snapshots #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exporting makeNewDataSnap in test-helpers
… root when trying writes
…mpler for api consumers
| @@ -278,7 +238,8 @@ Ruleset.prototype.tryWrite = function(path, root, newData, auth, skipWrite, skip | |||
| // write encompasses both the cascading write rules and the | |||
| // non-cascading validate rules | |||
|
|
|||
| var newDataRoot = makeNewDataSnap(path, RuleDataSnapshot.convert(newData)); | |||
| var newDataRoot = makeNewDataSnap(path, newData); | |||
| newDataRoot = root.merge(newDataRoot) | |||
There was a problem hiding this comment.
Can you put these on one line, like so:
var newDataRoot = root.merge(makeNewDataSnap(path, newData));
|
This solves a whole host of problems. Thank you so much for submitting. Once that one change is made, I'll merge and release. |
|
Happy to help :) |
|
LGTM |
This was referenced May 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26 by merging root and newData when trying writes.