Skip to content

Commit

Permalink
Merge pull request #94 from dinoboff/simpler-tests
Browse files Browse the repository at this point in the history 
Simpler tests
  • Loading branch information
@dinoboff
dinoboff authored Dec 8, 2016
2 parents 94eb7d4 + a72dddf commit 1970ff5
Show file tree
Hide file tree
Showing 5 changed files with 646 additions and 828 deletions.
3 changes: 2 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"format": "npm run lint -- --fix",
"lint": "eslint lib/ plugins/ test/ bin/targaryen",
"lint:html": "(npm run -s lint -- --max-warnings 0 -f html -o lint.html && rm lint.html) || echo 'open lint.html for linting errors'",
"test": "mocha -r test/setup.js test/spec/ --recursive && jasmine && node ./bin/targaryen --verbose test/integration/rules.json test/integration/tests.json"
"test": "mocha -r test/setup.js test/spec/ --recursive && jasmine && node ./bin/targaryen --verbose test/integration/rules.json test/integration/tests.json",
"test:inspect": "node --inspect --debug-brk node_modules/.bin/_mocha -r test/setup.js test/spec/ --recursive"
},
"author": "Harry Schmidt <[email protected]>",
"license": "ISC",
Expand Down
359 changes: 73 additions & 286 deletions test/jasmine/core.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,315 +5,102 @@
'use strict';

const targaryen = require('../../plugins/jasmine');
const util = require('../../lib/util');

describe('the targaryen Jasmine plugin', function() {

beforeEach(function() {
jasmine.addMatchers(targaryen.matchers);
util.resetFirebase();
});

describe('if not configured correctly', function() {

it('errors on any expectation', function() {

expect(function() {
expect(null).canRead('foo');
}).toThrow();

expect(function() {
expect(null).cannotRead('foo');
}).toThrow();

expect(function() {
expect(null).canWrite('foo', 7);
}).toThrow();

expect(function() {
expect(null).cannotWrite('foo', 7);
}).toThrow();

});
it('should throw if rules are not set', function() {
targaryen.setFirebaseData(null);

expect(() => expect(null).canRead('foo')).toThrow();
expect(() => expect(null).cannotRead('foo')).toThrow();
expect(() => expect(null).canWrite('foo', 7)).toThrow();
expect(() => expect(null).cannotWrite('foo', 7)).toThrow();
});

describe('if configured correctly', function() {

beforeEach(function() {

targaryen.setFirebaseData({
users: {
'password:500f6e96-92c6-4f60-ad5d-207253aee4d3': {
name: 'Sherlock Holmes'
},
'password:3403291b-fdc9-4995-9a54-9656241c835d': {
name: 'John Watson'
}

}
});

targaryen.setFirebaseRules({
rules: {
users: {
$user: {
'.read': 'auth !== null',
'.write': 'auth.uid === $user'
}
},
posts: {
$post: {
'.read': true,
'.write': 'newData.child("author").val() == auth.uid'
}
}
}
});

});

it('runs tests against the provided data and rules', function() {
it('should throw if data is not set', function() {
targaryen.setFirebaseRules({rules: {'.read': true, '.write': true}});

expect(targaryen.users.password).canRead('users/password:500f6e96-92c6-4f60-ad5d-207253aee4d3');
expect(targaryen.users.unauthenticated).canRead('posts/first');
expect(targaryen.users.unauthenticated).cannotRead('users/password:500f6e96-92c6-4f60-ad5d-207253aee4d3');
expect(() => expect(null).canRead('foo')).toThrow();
expect(() => expect(null).canWrite('foo', 7)).toThrow();

expect(targaryen.users.password)
.canWrite('users/password:500f6e96-92c6-4f60-ad5d-207253aee4d3', {name: 'Sherlock Holmes, Ph.D'});
expect(targaryen.users.password)
.cannotWrite('posts/newpost', {author: 'password:3403291b-fdc9-4995-9a54-9656241c835d'});

});
targaryen.setFirebaseRules({rules: {'.read': false, '.write': false}});

expect(() => expect(null).cannotRead('foo')).toThrow();
expect(() => expect(null).cannotWrite('foo', 7)).toThrow();
});

describe('deep write', function() {
beforeEach(function() {
targaryen.setFirebaseData(
{flats: {'221bbakerst': {landlady: 'Mrs Hudson'}}}
);
targaryen.setFirebaseRules({
rules: {
flats: {
$cid: {
'.validate': 'newData.hasChildren([\'landlady\'])',
'.write': 'true',
'.read': 'true'
}
}
it('should test read access', function() {
targaryen.setFirebaseData(null);
targaryen.setFirebaseRules({rules: {
'.read': false,
foo: {
bar: {
'.read': 'auth.uid !== null'
}
});
});
it('should not check parent validations', function() {
expect({uid: 'holmes'}).canWrite('/flats/221bbakerst/tenants/Holmes', {});
});
});
}
}});

describe('canPatch', function() {
beforeEach(function() {
targaryen.setFirebaseData({
users: {
'some-provider:1': {
name: 'Sherlock Holmes'
},
'some-provider:2': {
name: 'John Watson'
}
},
posts: {
somePost: {
author: 'some-provider:1',
created: Date.now(),
text: 'Hello!'
}
}
});
expect(targaryen.users.unauthenticated).cannotRead('/');
expect(targaryen.users.unauthenticated).cannotRead('/foo');
expect(targaryen.users.unauthenticated).cannotRead('/foo/bar');

targaryen.setFirebaseRules({
rules: {
users: {
$user: {
'.read': 'auth.uid === $user',
'.write': 'auth.isSuper === true'
}
},
posts: {
$post: {
'.read': true,
'.write': true,
'.validate': 'newData.hasChildren(["created", "text", "author"]) && newData.child("author").val() === auth.uid',
created: {
'.validate': 'data.exists() == false'
},
author: {
'.validate': 'data.exists() == false'
}
}
}
}
});
});
it('should test a patch operation is allowed', function() {
expect({uid: 'some-provider:1'}).canPatch('/posts/somePost', {
text: 'Hello World!'
});
});
it('should test a patch operation is not allowed', function() {
expect({uid: 'some-provider:1'}).cannotPatch('/posts/somePost', {
text: 'Hello World!',
created: Date.now()
});
});
expect(targaryen.users.facebook).cannotRead('/');
expect(targaryen.users.facebook).cannotRead('/foo');
expect(targaryen.users.facebook).canRead('/foo/bar');
});

describe('using nested variables in path', function() {

beforeEach(function() {
// using double quotes to make the data & rules compatible with Firebase (web interface)

targaryen.setFirebaseData({
users: {
password: {
'password:500f6e96-92c6-4f60-ad5d-207253aee4d3': {
name: 'Sherlock Holmes'
},
'password:3403291b-fdc9-4995-9a54-9656241c835d': {
name: 'John Watson'
}
}
},
first: {
second: {
third: {
any: 'value'
}
}
it('should test write access', function() {
targaryen.setFirebaseData(null);
targaryen.setFirebaseRules({rules: {
'.write': false,
foo: {
bar: {
'.write': 'auth.uid !== null',
'.validate': 'newData.val() > 1'
}
});

targaryen.setFirebaseRules({
rules: {
users: {
$provider: {
$user: {
// all data is personal (read and write)
'.read': 'auth !== null && auth.uid === $user && auth.provider === $provider',
'.write': 'auth !== null && auth.uid === $user && auth.provider === $provider'
}
}
},
posts: {
$post: {
'.read': true,
'.write': 'newData.child(\'author\').val() == auth.uid'
}
},
$one: {
$two: {
$three: {
'.read': '$one == \'first\' && $two == \'second\' && $three == \'third\''
}
}
}
}
});

});

it('should allow read based on auth uid and provider', function() {
expect(targaryen.users.password).canRead('users/password/password:500f6e96-92c6-4f60-ad5d-207253aee4d3');
});

it('should allow read based on 3 path segment names', function() {
expect(targaryen.users.unauthenticated).canRead('first/second/third');
});

}
}});

expect(targaryen.users.unauthenticated).cannotWrite('/', 2);
expect(targaryen.users.unauthenticated).cannotWrite('/foo', 2);
expect(targaryen.users.unauthenticated).cannotWrite('/foo/bar', 1);
expect(targaryen.users.unauthenticated).cannotWrite('/foo/bar', 2);

expect(targaryen.users.facebook).cannotWrite('/', 2);
expect(targaryen.users.facebook).cannotWrite('/foo', 2);
expect(targaryen.users.facebook).cannotWrite('/foo/bar', 1);
expect(targaryen.users.facebook).canWrite('/foo/bar', 2);
});

describe('delete nodes', function() {
beforeEach(function() {
targaryen.setFirebaseData({
test: {
number: 42,
bool: true
},
canDelete: 'test',
otherCanDelete: 'test'
});
targaryen.setFirebaseRules({
rules: {
test: {
'.write': 'true',
'.read': 'true',
'.validate': 'newData.hasChildren([\'number\', \'bool\'])',
number: {
'.validate': 'newData.isNumber()'
},
bool: {
'.validate': 'newData.isBoolean()'
}
},
canDelete: {
'.read': 'true',
'.write': 'true',
'.validate': 'newData.isString()'
},
shouldValidate: {
'.read': 'true',
'.write': 'true',
'.validate': 'newData.isBoolean()'
},
otherCanDelete: {
'.read': 'true',
'.write': 'true',
'.validate': 'newData.isString()'
}
it('should test multi write access', function() {
targaryen.setFirebaseData(null);
targaryen.setFirebaseRules({rules: {
'.write': false,
foo: {
$key: {
'.write': 'auth.uid !== null',
'.validate': 'newData.val() > 1'
}
});
});

it('should not be able to delete /test/number', function() {
expect({uid: 'anyone'}).cannotWrite('test/number', null);
});

it('should be able to delete /test', function() {
expect({uid: 'anyone'}).canWrite('test', null);
});

it('should be able to delete /canDelete', function() {
expect({uid: 'anyone'}).canWrite('canDelete', null);
});

it('should not be able to delete part of /test in a multi-update', function() {
expect({uid: 'anyone'}).cannotPatch('/', {
'test/bool': null,
canDelete: null
});
});

it('should be able to delete as part of a multi-path write', function() {
expect({uid: 'anyone'}).canPatch('/', {
test: {
bool: false,
number: 5
},
canDelete: null
});
});

it('should be able to delete a whole object by nulling all children', function() {
expect({uid: 'anyone'}).canWrite('test', {
bool: null,
number: null
});
});

it('should not be able to write invalid data by deleting a sibling', function() {
expect({uid: 'anyone'}).cannotWrite('/', {
canDelete: null,
shouldValidate: 'not a boolean',
otherCanDelete: null
});
});

}
}});

expect(targaryen.users.unauthenticated).cannotPatch('/', {foo: {bar: 2, baz: 2}});
expect(targaryen.users.unauthenticated).cannotPatch('/', {'foo/bar': 1, 'foo/baz': 2});
expect(targaryen.users.unauthenticated).cannotPatch('/', {'foo/bar': 2, 'foo/baz': 2});
expect(targaryen.users.unauthenticated).cannotPatch('/foo', {bar: 1, baz: 2});
expect(targaryen.users.unauthenticated).cannotPatch('/foo', {bar: 2, baz: 2});

expect(targaryen.users.facebook).cannotPatch('/', {foo: {bar: 2, baz: 2}});
expect(targaryen.users.facebook).cannotPatch('/', {'foo/bar': 1, 'foo/baz': 2});
expect(targaryen.users.facebook).canPatch('/', {'foo/bar': 2, 'foo/baz': 2});
expect(targaryen.users.facebook).cannotPatch('/foo', {bar: 1, baz: 2});
expect(targaryen.users.facebook).canPatch('/foo', {bar: 2, baz: 2});
});

});
Loading

0 comments on commit 1970ff5

Please sign in to comment.