Fix #78: log all warnings #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
force-pushed
the
feature/log-all-warnings
branch
from
ddc0a88
to
c97d763
Compare
golangci
reviewed
Jun 14, 2018
| type LogLevel int | ||
|
|
||
| const ( | ||
| // debug message, write to debug logs only by logutils.Debug |
There was a problem hiding this comment.
comment on exported const LogLevelDebug should be of the form "LogLevelDebug ..."
| // debug message, write to debug logs only by logutils.Debug | ||
| LogLevelDebug LogLevel = 0 | ||
|
|
||
| // information messages, don't write too much messages, |
There was a problem hiding this comment.
comment on exported const LogLevelInfo should be of the form "LogLevelInfo ..."
| // only useful ones: they are shown when running with -v | ||
| LogLevelInfo LogLevel = 1 | ||
|
|
||
| // hidden errors: non critical errors: work can be continued, no need to fail whole program; |
There was a problem hiding this comment.
comment on exported const LogLevelWarn should be of the form "LogLevelWarn ..."
| // tests will crash if any warning occured. | ||
| LogLevelWarn LogLevel = 2 | ||
|
|
||
| // only not hidden from user errors: whole program failing, usually |
There was a problem hiding this comment.
comment on exported const LogLevelError should be of the form "LogLevelError ..."
golangci
force-pushed
the
feature/log-all-warnings
branch
from
c97d763
to
c2bad40
Compare
1. Log all warnings, don't hide none of them 2. Write fatal messages (stop analysis) with error log level 3. Remove ugly timestamp counter from logrus output 4. Print nested module prefix in log 5. Make logger abstraction: no global logging anymore 6. Refactor config reading to config.FileReader struct to avoid passing logger into every function 7. Replace exit codes hardcoding with constants in exitcodes package 8. Fail test if any warning was logged 9. Fix calculation of relative path if we analyze parent dir ../ 10. Move Runner initialization from Executor to NewRunner func 11. Log every AST parsing error 12. Properly print used config file path in verbose mode 13. Print package files if only 1 package is analyzedin verbose mode, print not compiling packages in verbose mode 14. Forbid usage of github.com/sirupsen/logrus by DepGuard linter 15. Add default ignore pattern to folint: "comment on exported const"
golangci
force-pushed
the
feature/log-all-warnings
branch
from
c2bad40
to
2bfd746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.