Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'--new-from-rev=master' flag not taking effect #30

Closed
jlucktay opened this issue Jul 3, 2020 · 2 comments
Closed

'--new-from-rev=master' flag not taking effect #30

jlucktay opened this issue Jul 3, 2020 · 2 comments

Comments

@jlucktay
Copy link

jlucktay commented Jul 3, 2020

We run this in some of our projects, and thank you all for the tool; it's fantastic!

I am noticing that the issues.new-from-rev: master setting in our .golangci.yml configuration file isn't effective, and this warning is in our GH Actions log:

level=warning msg="[runner] Can't process result by diff processor: can't prepare diff by revgrep: could not read git repo: error executing git diff \"master\" \"\": exit status 128"

Does it seem like the Action can't find the current revision hash to diff against master?

@CyrusJavan
Copy link

Use only-new-issues: true in your action yml instead. I had your exact issue, using only-new-issues: true will accomplish the same effect as issues.new-from-rev: master

      - name: golangci-lint
        uses: golangci/golangci-lint-action@v1
        with:
          version: v1.26
          only-new-issues: true

@jlucktay
Copy link
Author

OK, thanks @CyrusJavan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants