Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/authzed/spicedb: GHSA-jhg6-6qrx-38mr #3131

Closed
GoVulnBot opened this issue Sep 18, 2024 · 2 comments
Assignees
Labels

Comments

@GoVulnBot
Copy link

Advisory GHSA-jhg6-6qrx-38mr references a vulnerability in the following Go modules:

Module
github.com/authzed/spicedb

Description:

Background

Multiple caveats over the same indirect subject type on the same relation can result in no permission being returned when permission is expected

For example, given this schema:

definition user {}

caveat somecaveat(somefield int) {
  somefield == 42
}

definition group {
  relation member: user
}

definition resource {
  relation viewer: group#member with somecaveat
  permission view = folder->view
}

If the resource has multiple groups, and each group is caveated, it is possible for the returned permission to be "no permission" when permission is expected.

Impact

...

References:

Cross references:

See doc/quickstart.md for instructions on how to triage this report.

id: GO-ID-PENDING
modules:
    - module: github.com/authzed/spicedb
      versions:
        - fixed: 1.35.3
      vulnerable_at: 1.35.2
summary: |-
    SpiceDB having multiple caveats on resources of the same type may improperly
    result in no permission in github.com/authzed/spicedb
cves:
    - CVE-2024-46989
ghsas:
    - GHSA-jhg6-6qrx-38mr
references:
    - advisory: https://github.com/advisories/GHSA-jhg6-6qrx-38mr
    - advisory: https://github.com/authzed/spicedb/security/advisories/GHSA-jhg6-6qrx-38mr
    - fix: https://github.com/authzed/spicedb/commit/20855de75812bcbc975efebe7f76abf47c0f3edb
source:
    id: GHSA-jhg6-6qrx-38mr
    created: 2024-09-18T18:01:26.58126039Z
review_status: UNREVIEWED

@zpavlinovic
Copy link
Contributor

#3132 is a duplicate of this issue.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/614079 mentions this issue: data/reports: add GO-2024-3131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants