Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in filippo.io/nistec: GHSA-f6hc-9g49-xmx7 #1601

Closed
GoVulnBot opened this issue Mar 1, 2023 · 1 comment
Closed
Assignees

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-f6hc-9g49-xmx7, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
filippo.io/nistec 0.0.2 < 0.0.2

Cross references:

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: filippo.io/nistec
    versions:
      - fixed: 0.0.2
    packages:
      - package: filippo.io/nistec
description: |-
    Multiplication of certain unreduced P-256 scalars produce incorrect results.

    There are no protocols known at this time that can be attacked due to this.

    From the fix commit notes:

    Unlike the rest of nistec, the P-256 assembly doesn't use complete
    addition formulas, meaning that p256PointAdd[Affine]Asm won't return the
    correct value if the two inputs are equal.

    This was (undocumentedly) ignored in the scalar multiplication loops
    because as long as the input point is not the identity and the scalar is
    lower than the order of the group, the addition inputs can't be the same.

    As part of the math/big rewrite, we went however from always reducing
    the scalar to only checking its length, under the incorrect assumption
    that the scalar multiplication loop didn't require reduction.
cves:
  - CVE-2023-24533
ghsas:
  - GHSA-f6hc-9g49-xmx7
references:
  - fix: https://github.com/FiloSottile/nistec/commit/c58aa1223ccf3943513e1e661cebce95af137244
  - report: https://go.dev/issue/58647
  - web: https://pkg.go.dev/vuln/GO-2023-1595
  - advisory: https://github.com/advisories/GHSA-f6hc-9g49-xmx7

@zpavlinovic zpavlinovic self-assigned this Mar 1, 2023
@zpavlinovic
Copy link
Contributor

Duplicate of #1595

@zpavlinovic zpavlinovic marked this as a duplicate of #1595 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants