-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snippets: add snippet for TestMain #629
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I don't care about all that bureaucracy. If you want, anyone reading this can take my contribution and resubmit it as theirs. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 3c1f73d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/254497 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/254497. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/254497. |
I understand that you want to move snippets to gopls. But until you tackle that plan, would you maybe accept this PR? The snippet can later still be migrated. If you prefer, I could also change the snippet from triggering on |
Message from Hyang-Ah Hana Kim: Patch Set 2: Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/254497. |
This is a natural extension of the existing test/benchmark functions snippets (tf, bf). Update #160 Change-Id: I9e787dea7fbcc063b1d1a13dffee6b09905120fe GitHub-Last-Rev: 3c1f73d GitHub-Pull-Request: #629 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254497 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Trust: Suzy Mueller <[email protected]>
Message from Suzy Mueller: Patch Set 2: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/254497. |
This PR is being closed because golang.org/cl/254497 has been merged. |
This is a natural extension of the existing test/benchmark functions snippets (tf, bf).
Update #160