go vet flag "-composite=false" is ignored by editor

[avivdolev]

What version of Go, VS Code & VS Code Go extension are you using?

• Run go version to get version of Go
  go version go1.14.4 linux/amd64
• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
  1.46.0
  a5d1cc28bb5da32ec67e86cc50f84c67cc690321
  x64
• Check your installed extensions to get the version of the VS Code Go extension
  0.14.4
• Run go env to get the go development environment details

GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/root/go/src/aviv/hello/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build321001936=/tmp/go-build -gno-record-gcc-switches"

Share the Go related settings you have added/edited

{
    "go.useLanguageServer": true,
    "go.vetFlags": [
        "-composites=false",
    ]
}

Describe the bug

go vet flag "-composites=false" is being ignored by the editor.
running go vet manually with this flag do not output any error.

Steps to reproduce the behavior:

example file hello.go:

package hello

import (
	"fmt"
	"image"
)

func hello() {
	fmt.Println([]image.CMYK{
		{[]uint8{}, 5, image.Rect(0, 0, 0, 0)},
	})
}

I get the following problem:

[
{
	"resource": "/root/go/src/aviv/hello/hello.go",
	"owner": "_generated_diagnostic_collection_name_#1",
	"severity": 4,
	"message": "image.CMYK composite literal uses unkeyed fields",
	"source": "composites",
	"startLineNumber": 10,
	"startColumn": 3,
	"endLineNumber": 10,
	"endColumn": 41
}
]

But running go vet -composites=false . manually show no error.
This does not replicate with a package main, nor with gopls turned off.

As far as I know, gopls does not "vet", vetting is still done by go vet, so I post the issue here and not on gopls repo - please let me know if I'm wrong.

Thank you,
Aviv

[hyangah]

@avivdolev what do you see if you manually invoke vet using Command Palette -> "Go: Vet Current Package"?
The exact command line used for vet should appear in the "Go" Output channel.

[avivdolev]

The same output as you posted- no vet errors

[hyangah]

you are using the language server.

gopls *does` vet check by default.
https://github.com/golang/tools/blob/master/gopls/doc/analyzers.md#composite

Can you try to configure gopls to disable it? I think the configuration looks like

"gopls": {
   "analyses": {  "composite": false }
}

https://github.com/golang/tools/blob/master/gopls/doc/settings.md#analyses-mapstringbool

@stamblerre I think either we should disable direct launch of vet entirely if gopls is enabled, or have the setting ("go.vetFlags") be correctly applied to gopls. What do you think?

[avivdolev]

Can you try to configure gopls to disable it? I think the configuration looks like

"gopls": {
   "analyses": {  "composite": false }
}

Doesn't seem to work (restarted gopls, reloaded vscode) :(
Double checked here:
https://github.com/golang/tools/blob/master/gopls/doc/analyzers.md
and the syntax seems right.

[hyangah]

Sorry - a documentation bug. Try "composites".

"gopls": {
        "analyses": { "composites": false }
 },

[avivdolev]

Worked! 🎉
Thank you :)

[hyangah]

Glad that it worked.
Sent a PR to fix the doc.
Let's continue discussion about cleaning up settings in #197