request: please keep the engine at 1.58

[OneOfOne]

This is related to microsoft/vscode#130457

A lot of us are hardlocking vscode to v1.58.x until we find an alternative, so would it be possible to use the 1.58 engine in package.json until there's a strong reason to switch to 1.59?

[hyangah]

Thanks for the info @OneOfOne
I thought VS Code users still could use v0.27.1 and marketplace would suggest only compatible versions of the extension. Is it not the case?

We wanted 1.59 to use the new test explorer API in the next release. @firelizzard18 Is it possible to have the extension still require 1.58, and enable the test explorer feature (and use of the new API) only if the api is available (i.e. user is using 1.59 or newer)?

UPDATE: I just tested with Go nightly, and it suggested 2021.8.619 version which is the last go nightly built with the ^1.52.0 engine requirement.

[firelizzard18]

@hyangah I added a commit to bump the engine back to 1.58 and hide the test controller registration behind a check. I think that should do it.

[firelizzard18]

[golang.go]: testing/item/context is a proposed menu identifier and is only available when running out of dev or with the following command line switch: --enable-proposed-api golang.go

The testing menu contribution blocks the extension from loading on 1.58.

[hyangah]

Thanks @firelizzard18 for investigating and filing the issue upstream.
It's unfortunate but I am voting to switch to 1.59 at least in nightly, and let users of vscode 1.58 keep using v0.27.1 or earlier versions.

[hyangah]

I will leave this issue open - we will reevaluate this decision during v0.28.0 release.

[OneOfOne]

Understandable, thank you for looking into it.

[firelizzard18]

The VSCode team is unwilling to support the tools necessary for this extension to utilize new features in a backwards compatible way: microsoft/vscode#130796 (comment).

[hyangah]

Noted the requirement in the change log.
Sorry that the vscode issues didn't go in the direction we wanted. I hope that v0.28.2 does not have critical issues and remains usable for users who can't upgrade.