From b5f15f589b9571ad79f201ee16c8d07d3f57fa81 Mon Sep 17 00:00:00 2001 From: Hana Date: Fri, 29 Jan 2021 16:20:19 -0500 Subject: [PATCH] [release] src/goMain: linkify documentLink deprecation warning message vscode show*Message API does not have full markdown formatting support but allows the use of links. Use it so users can access the info easily. Change-Id: I4eff7c128bdf97ba4ff0375e957daa77ed4f9369 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/288133 Trust: Hyang-Ah Hana Kim Run-TryBot: Hyang-Ah Hana Kim Reviewed-by: Rebecca Stambler (cherry picked from commit bc53fd8ee162ef0595ec63bb33e23cfaed86bcaf) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/288212 TryBot-Result: kokoro --- src/goMain.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/goMain.ts b/src/goMain.ts index fe7d445d00..54a0166ebf 100644 --- a/src/goMain.ts +++ b/src/goMain.ts @@ -128,15 +128,14 @@ export async function activate(ctx: vscode.ExtensionContext) { // The `diagnostics` setting is still used as a workaround for running custom vet. if (experimentalFeatures['documentLink'] === false) { vscode.window.showErrorMessage(`The 'go.languageServerExperimentalFeature.documentLink' setting is now deprecated. -Please use ' "gopls": {"ui.navigation.importShortcut": "Definition" }' instead. -See https://github.com/golang/vscode-go/blob/master/docs/settings.md#uinavigationimportshortcut for more details.`); +Please use '"gopls": {"ui.navigation.importShortcut": "Definition" }' instead. +See [the settings doc](https://github.com/golang/vscode-go/blob/master/docs/settings.md#uinavigationimportshortcut) for more details.`); } const promptKey = 'promptedLanguageServerExperimentalFeatureDeprecation'; const prompted = getFromGlobalState(promptKey, false); if (!prompted && experimentalFeatures['diagnostics'] === false) { const msg = `The 'go.languageServerExperimentalFeature.diagnostics' setting will be deprecated soon. -If you would like additional configuration for diagnostics from gopls, please see and response to -https://github.com/golang/vscode-go/issues/50.`; +If you would like additional configuration for diagnostics from gopls, please see and response to [Issue 50](https://github.com/golang/vscode-go/issues/50).`; const selected = await vscode.window.showInformationMessage(msg, `Don't show again`); switch (selected) { case `Don't show again`: